pdn: adjust naming to Google-style (excluding method names)#10192
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request performs an extensive refactoring of the PDN generation module to standardize naming conventions across the codebase. The changes primarily involve renaming enumeration members and static constants to use the kPascalCase prefix, as well as converting function parameters and local variables from camelCase to snake_case. The review feedback suggests further aligning with C++ style guidelines by using pointers instead of references for output parameters in the findRingShapes function.
| std::vector<odb::dbSBox*> SRoute::findRingShapes(odb::dbNet* net, | ||
| uint32_t& h_dy) |
There was a problem hiding this comment.
According to the Google C++ Style Guide, output parameters should be passed by pointer rather than by reference. This makes it explicit at the call site that the variable may be modified.
| std::vector<odb::dbSBox*> SRoute::findRingShapes(odb::dbNet* net, | |
| uint32_t& h_dy) | |
| std::vector<odb::dbSBox*> SRoute::findRingShapes(odb::dbNet* net, | |
| uint32_t* h_dy) |
References
- Function parameters should be passed by value or by const reference. Use pointers for output parameters. (link)
| const char* iterm_name, | ||
| const std::vector<odb::dbSBox*>& ring); | ||
| std::vector<odb::dbSBox*> findRingShapes(odb::dbNet* net, uint32_t& Hdy); | ||
| std::vector<odb::dbSBox*> findRingShapes(odb::dbNet* net, uint32_t& h_dy); |
There was a problem hiding this comment.
As noted in the implementation, output parameters should be passed by pointer to adhere to the Google C++ Style Guide.
| std::vector<odb::dbSBox*> findRingShapes(odb::dbNet* net, uint32_t& h_dy); | |
| std::vector<odb::dbSBox*> findRingShapes(odb::dbNet* net, uint32_t* h_dy); |
References
- Function parameters should be passed by value or by const reference. Use pointers for output parameters. (link)
|
clang-tidy review says "All clean, LGTM! 👍" |
Summary
adjust naming to Google-style (excluding method names)
Type of Change
Impact
None
Verification
./etc/Build.sh).