rmp: adjust naming to Google-style (excluding method names) by openroad-ci · Pull Request #10193 · The-OpenROAD-Project/OpenROAD

openroad-ci · 2026-04-19T22:55:18Z

Summary

adjust naming to Google-style (excluding method names)

Type of Change

Refactoring

Impact

None

Verification

I have verified that the local build succeeds (./etc/Build.sh).
I have run the relevant tests and they pass.
My code follows the repository's formatting guidelines.
I have signed my commits (DCO).

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

gemini-code-assist

Code Review

This pull request refactors naming conventions for enums and variables to a consistent style and adds linting suppressions for external library declarations. Feedback focuses on optimizing loops in Restructure.cpp by using references to avoid string copies and caching redundant function calls, as well as improving readability by storing repeated boolean conditions.

gemini-code-assist · 2026-04-19T22:57:36Z

+      for (auto pin_name : *error) {
+        debugPrint(logger_, RMP, "remap", 1, "Unconstrained pin: {}", pin_name);
+        if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {
+          ends.insert(open_sta_->getDbNetwork()->findPin(pin_name.c_str()));
        }
        first = false;
      }


Iterating by value causes unnecessary string copies. Additionally, following the principle of analyzing loop structures to avoid redundancy, findPin should not be called multiple times for the same pin. Consider using a reference and caching the result to improve efficiency.

Suggested change

for (auto pin_name : *error) {

debugPrint(logger_, RMP, "remap", 1, "Unconstrained pin: {}", pin_name);

if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {

ends.insert(open_sta_->getDbNetwork()->findPin(pin_name.c_str()));

}

first = false;

}

for (const auto& pin_name : *error) {

debugPrint(logger_, RMP, "remap", 1, "Unconstrained pin: {}", pin_name);

if (!first) {

if (auto* pin = open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {

ends.insert(pin);

}

}

first = false;

}

References

When analyzing code within a loop, consider the entire loop structure to identify and remove redundant operations within the loop body.

gemini-code-assist · 2026-04-19T22:57:36Z

+      for (auto pin_name : *error) {
+        debugPrint(logger_, RMP, "remap", 1, "Unclocked pin: {}", pin_name);
+        if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {
+          ends.insert(open_sta_->getDbNetwork()->findPin(pin_name.c_str()));
        }
        first = false;
      }


Iterating by value causes unnecessary string copies. Additionally, following the principle of analyzing loop structures to avoid redundancy, findPin should not be called multiple times for the same pin. Consider using a reference and caching the result to improve efficiency.

for (const auto& pin_name : *error) { debugPrint(logger_, RMP, "remap", 1, "Unclocked pin: {}", pin_name); if (!first) { if (auto* pin = open_sta_->getDbNetwork()->findPin(pin_name.c_str())) { ends.insert(pin); } } first = false; }

References

When analyzing code within a loop, consider the entire loop structure to identify and remove redundant operations within the loop body.

gemini-code-assist · 2026-04-19T22:57:36Z

+          odb::dbMaster* const_master = (pin_val == sta::LogicValue::one)
                                            ? hicell_master
                                            : locell_master;
          odb::dbMTerm* const_port
-              = (pinVal == sta::LogicValue::one) ? hiterm : loterm;
+              = (pin_val == sta::LogicValue::one) ? hiterm : loterm;


The condition pin_val == sta::LogicValue::one is evaluated twice. Storing the result in a descriptive boolean variable improves readability and provides a minor performance optimization.

Suggested change

odb::dbMaster* const_master = (pin_val == sta::LogicValue::one)

? hicell_master

: locell_master;

odb::dbMTerm* const_port

= (pinVal == sta::LogicValue::one) ? hiterm : loterm;

= (pin_val == sta::LogicValue::one) ? hiterm : loterm;

const bool is_one = (pin_val == sta::LogicValue::one);

odb::dbMaster* const_master = is_one ? hicell_master : locell_master;

odb::dbMTerm* const_port = is_one ? hiterm : loterm;

github-actions

clang-tidy made some suggestions

github-actions · 2026-04-19T23:03:39Z

-        debugPrint(logger_, RMP, "remap", 1, "Unconstrained pin: {}", pinName);
-        if (!first && open_sta_->getDbNetwork()->findPin(pinName.c_str())) {
-          ends.insert(open_sta_->getDbNetwork()->findPin(pinName.c_str()));
+      for (auto pin_name : *error) {


warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]

Suggested change

for (auto pin_name : *error) {

for (const auto& pin_name : *error) {

github-actions · 2026-04-19T23:03:39Z

-          ends.insert(open_sta_->getDbNetwork()->findPin(pinName.c_str()));
+      for (auto pin_name : *error) {
+        debugPrint(logger_, RMP, "remap", 1, "Unconstrained pin: {}", pin_name);
+        if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {


warning: redundant call to 'c_str' [readability-redundant-string-cstr]

Suggested change

if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {

if (!first && open_sta_->getDbNetwork()->findPin(pin_name)) {

github-actions · 2026-04-19T23:03:39Z

+      for (auto pin_name : *error) {
+        debugPrint(logger_, RMP, "remap", 1, "Unconstrained pin: {}", pin_name);
+        if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {
+          ends.insert(open_sta_->getDbNetwork()->findPin(pin_name.c_str()));


warning: redundant call to 'c_str' [readability-redundant-string-cstr]

Suggested change

ends.insert(open_sta_->getDbNetwork()->findPin(pin_name.c_str()));

ends.insert(open_sta_->getDbNetwork()->findPin(pin_name));

github-actions · 2026-04-19T23:03:39Z

-        debugPrint(logger_, RMP, "remap", 1, "Unclocked pin: {}", pinName);
-        if (!first && open_sta_->getDbNetwork()->findPin(pinName.c_str())) {
-          ends.insert(open_sta_->getDbNetwork()->findPin(pinName.c_str()));
+      for (auto pin_name : *error) {


warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]

Suggested change

for (auto pin_name : *error) {

for (const auto& pin_name : *error) {

github-actions · 2026-04-19T23:03:39Z

-          ends.insert(open_sta_->getDbNetwork()->findPin(pinName.c_str()));
+      for (auto pin_name : *error) {
+        debugPrint(logger_, RMP, "remap", 1, "Unclocked pin: {}", pin_name);
+        if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {


warning: redundant call to 'c_str' [readability-redundant-string-cstr]

Suggested change

if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {

if (!first && open_sta_->getDbNetwork()->findPin(pin_name)) {

github-actions · 2026-04-19T23:03:39Z

+      for (auto pin_name : *error) {
+        debugPrint(logger_, RMP, "remap", 1, "Unclocked pin: {}", pin_name);
+        if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {
+          ends.insert(open_sta_->getDbNetwork()->findPin(pin_name.c_str()));


warning: redundant call to 'c_str' [readability-redundant-string-cstr]

Suggested change

ends.insert(open_sta_->getDbNetwork()->findPin(pin_name.c_str()));

ends.insert(open_sta_->getDbNetwork()->findPin(pin_name));

rmp: adjust naming to Google-style (excluding method names)

d53b883

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

openroad-ci assigned maliberty Apr 19, 2026

github-actions Bot added the size/M label Apr 19, 2026

gemini-code-assist Bot reviewed Apr 19, 2026

View reviewed changes

github-actions Bot reviewed Apr 19, 2026

View reviewed changes

maliberty approved these changes Apr 19, 2026

View reviewed changes

maliberty merged commit 3295560 into The-OpenROAD-Project:master Apr 19, 2026
16 of 17 checks passed

maliberty deleted the rmp-tidy-naming branch April 19, 2026 23:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rmp: adjust naming to Google-style (excluding method names)#10193

rmp: adjust naming to Google-style (excluding method names)#10193
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:rmp-tidy-naming

openroad-ci commented Apr 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 19, 2026

Uh oh!

gemini-code-assist Bot Apr 19, 2026

Uh oh!

gemini-code-assist Bot Apr 19, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot Apr 19, 2026

Uh oh!

github-actions Bot Apr 19, 2026

Uh oh!

github-actions Bot Apr 19, 2026

Uh oh!

github-actions Bot Apr 19, 2026

Uh oh!

github-actions Bot Apr 19, 2026

Uh oh!

github-actions Bot Apr 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	for (auto pin_name : *error) {
	for (const auto& pin_name : *error) {

	if (!first && open_sta_->getDbNetwork()->findPin(pin_name.c_str())) {
	if (!first && open_sta_->getDbNetwork()->findPin(pin_name)) {

	ends.insert(open_sta_->getDbNetwork()->findPin(pin_name.c_str()));
	ends.insert(open_sta_->getDbNetwork()->findPin(pin_name));

Uh oh!

Conversation

openroad-ci commented Apr 19, 2026

Summary

Type of Change

Impact

Verification

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants