tap: adjust naming to Google-style (excluding method names)#10195
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request applies code style and linting updates across several files. It introduces NOLINT annotations to result_type aliases to address naming convention warnings and renames enum members in EdgeType and CornerType to follow the k prefix naming standard. I have no feedback to provide.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| prev_pt = pt; | ||
|
|
||
| edges.push_back(Edge{EdgeType::Unknown, pt0, pt1}); | ||
| edges.push_back(Edge{EdgeType::kUnknown, pt0, pt1}); |
There was a problem hiding this comment.
warning: use designated initializer list to initialize 'Edge' [modernize-use-designated-initializers]
| edges.push_back(Edge{EdgeType::kUnknown, pt0, pt1}); | |
| edges.push_back(Edge{.type=EdgeType::kUnknown, .pt0=pt0, .pt1=pt1}); |
Additional context
src/tap/include/tap/tapcell.h:108: aggregate type is defined here
struct Edge
^| const odb::Point pt0(prev_pt.x(), prev_pt.y()); | ||
| const odb::Point pt1((*area.begin()).x(), (*area.begin()).y()); | ||
| edges.push_back(Edge{EdgeType::Unknown, pt0, pt1}); | ||
| edges.push_back(Edge{EdgeType::kUnknown, pt0, pt1}); |
There was a problem hiding this comment.
warning: use designated initializer list to initialize 'Edge' [modernize-use-designated-initializers]
| edges.push_back(Edge{EdgeType::kUnknown, pt0, pt1}); | |
| edges.push_back(Edge{.type=EdgeType::kUnknown, .pt0=pt0, .pt1=pt1}); |
Additional context
src/tap/include/tap/tapcell.h:108: aggregate type is defined here
struct Edge
^| for (const auto& pt : area) { | ||
| const odb::Point corner(pt.x(), pt.y()); | ||
| corners.push_back(Corner{CornerType::Unknown, corner}); | ||
| corners.push_back(Corner{CornerType::kUnknown, corner}); |
There was a problem hiding this comment.
warning: use designated initializer list to initialize 'Corner' [modernize-use-designated-initializers]
| corners.push_back(Corner{CornerType::kUnknown, corner}); | |
| corners.push_back(Corner{.type=CornerType::kUnknown, .pt=corner}); |
Additional context
src/tap/include/tap/tapcell.h:134: aggregate type is defined here
struct Corner
^
maliberty
merged commit dc90327
into
The-OpenROAD-Project:master
2 participants
Summary
adjust naming to Google-style (excluding method names)
Type of Change
Impact
None
Verification
./etc/Build.sh).