Skip to content

tap: adjust naming to Google-style (excluding method names) #10195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 1 commit into from
Apr 20, 2026
Merged

tap: adjust naming to Google-style (excluding method names) #10195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gui/src/search.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class Search : public QObject, public odb::dbBlockCallBackObj
template <typename T>
struct BBoxIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(T t) const { return t->getBBox()->getBox(); }
odb::Rect operator()(const SNetValue<T>& t) const
{
Expand All @@ -85,7 +85,7 @@ class Search : public QObject, public odb::dbBlockCallBackObj

struct FillIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(odb::dbFill* t) const
{
odb::Rect fill;
Expand Down
4 changes: 2 additions & 2 deletions src/pdn/src/power_cells.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class GridSwitchedPower

struct InstIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(odb::dbInst* inst) const
{
return inst->getBBox()->getBox();
Expand All @@ -136,7 +136,7 @@ class GridSwitchedPower

struct RowIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(odb::dbRow* row) const { return row->getBBox(); }
};
using RowTree
Expand Down
4 changes: 2 additions & 2 deletions src/pdn/src/shape.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ class Shape
};
struct RectIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(const ShapePtr& t) const { return t->getRect(); }
};
struct ObstructionIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(const ShapePtr& t) const
{
return t->getObstruction();
Expand Down
2 changes: 1 addition & 1 deletion src/pdn/src/via.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ class Via
public:
struct ViaIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(const ViaPtr& via) const { return via->getArea(); }
};
using ViaTree = bgi::rtree<ViaPtr, bgi::quadratic<16>, ViaIndexableGetter>;
Expand Down
4 changes: 2 additions & 2 deletions src/psm/src/ir_network.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ namespace psm {
template <typename T>
struct RectIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(const T* t) const { return t->getShape(); }
};

template <typename T>
struct PointIndexableGetter
{
using result_type = odb::Point;
using result_type = odb::Point; // NOLINT(readability-identifier-naming)
odb::Point operator()(const T* t) const { return t->getPoint(); }
};

Expand Down
30 changes: 15 additions & 15 deletions src/tap/include/tap/tapcell.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ class Tapcell
private:
enum class EdgeType
{
Left,
Top,
Right,
Bottom,
Unknown
kLeft,
kTop,
kRight,
kBottom,
kUnknown
};
struct Edge
{
Expand All @@ -115,15 +115,15 @@ class Tapcell
};
enum class CornerType
{
OuterBottomLeft,
OuterTopLeft,
OuterTopRight,
OuterBottomRight,
InnerBottomLeft,
InnerTopLeft,
InnerTopRight,
InnerBottomRight,
Unknown
kOuterBottomLeft,
kOuterTopLeft,
kOuterTopRight,
kOuterBottomRight,
kInnerBottomLeft,
kInnerTopLeft,
kInnerTopRight,
kInnerBottomRight,
kUnknown
};
struct PartialOverlap
{
Expand All @@ -143,7 +143,7 @@ class Tapcell

struct InstIndexableGetter
{
using result_type = odb::Rect;
using result_type = odb::Rect; // NOLINT(readability-identifier-naming)
odb::Rect operator()(odb::dbInst* inst) const
{
return inst->getBBox()->getBox();
Expand Down
Loading
Loading