web: adjust naming to Google-style (excluding method names)#10197
Conversation
There was a problem hiding this comment.
Code Review
This pull request performs a broad refactoring of naming conventions within the web component to align with a consistent style. Key changes include renaming enum members, constants, and static variables to use a 'k' prefix, as well as converting several function and lambda names to snake_case. A critical issue was identified in tile_generator.cpp where the rename of the raw_json member variable was not fully applied, which will result in a compilation error.
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
a1bd752 to
b614897
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@codex review |
|
/gemini review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Code Review
This pull request refactors naming conventions across the web reporting and request handling modules to align with a consistent coding style. Key changes include updating enum members, local constants, and static variables to use the 'k' prefix (e.g., kRoot, kTile) and converting several camelCase lambda and function names to snake_case. I have no feedback to provide as there are no review comments.
ad8342c
into
The-OpenROAD-Project:master
Summary
adjust naming to Google-style (excluding method names)
Type of Change
Impact
None
Verification
./etc/Build.sh).