Skip to content

web: adjust naming to Google-style (excluding method names)#10197

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:web-tidy-naming
Apr 20, 2026
Merged

web: adjust naming to Google-style (excluding method names)#10197
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:web-tidy-naming

Conversation

@openroad-ci

Copy link
Copy Markdown
Member

Summary

adjust naming to Google-style (excluding method names)

Type of Change

  • Refactoring

Impact

None

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a broad refactoring of naming conventions within the web component to align with a consistent style. Key changes include renaming enum members, constants, and static variables to use a 'k' prefix, as well as converting several function and lambda names to snake_case. A critical issue was identified in tile_generator.cpp where the rename of the raw_json member variable was not fully applied, which will result in a compilation error.

Comment thread src/web/src/tile_generator.h

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/web/src/tile_generator.cpp Outdated
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@openroad-ci openroad-ci force-pushed the web-tidy-naming branch 2 times, most recently from a1bd752 to b614897 Compare April 20, 2026 07:20
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty

Copy link
Copy Markdown
Member

@codex review

@maliberty

Copy link
Copy Markdown
Member

/gemini review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors naming conventions across the web reporting and request handling modules to align with a consistent coding style. Key changes include updating enum members, local constants, and static variables to use the 'k' prefix (e.g., kRoot, kTile) and converting several camelCase lambda and function names to snake_case. I have no feedback to provide as there are no review comments.

@maliberty maliberty merged commit ad8342c into The-OpenROAD-Project:master Apr 20, 2026
15 of 16 checks passed
@maliberty maliberty deleted the web-tidy-naming branch April 20, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants