Fix bazel build //:tarfile#10198
Merged
maliberty merged 1 commit intoApr 20, 2026
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 20, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the visibility of the openroad.tar package in packaging/BUILD.bazel to public. The review feedback suggests using more restrictive visibility settings instead of public to maintain better encapsulation while still providing the necessary access for the root package and tests.
The packaging target wasn't public and it failed to be referenced by the top-level alias, mirroring the earlier //:install fix. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
openroad-ci
force-pushed
the
fix-bazel-tarfile-visibility
branch
from
b60bacb to
2dc9e2a
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
merged commit 09cc082
into
The-OpenROAD-Project:master
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//packaging:tarfilewas only visible to//test:__subpackages__, which broke the top-level//:tarfilealias. Mirrors the earlier//:installvisibility fix (836bbe9).Type of Change
Impact
Restores
bazel build //:tarfile(andbazel build //...) on master.Verification
bazel build //:openroad //:install //:tarfile).Related Issues
None.