odb: Expose hpwl api as public in WireLengthEvaluator and fix issue in reportEachNetHpwl.#10214
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the WireLengthEvaluator class by making the hpwl method public. Feedback indicates that the implementation lacks initialization for output parameters in specific cases, which poses a risk now that the method is accessible externally. Additionally, a bug involving reference aliasing in an existing caller was identified, suggesting a need for API refactoring to return a struct or pair for improved safety.
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
…n reportEachNetHpwl. Signed-off-by: Ted Hong <tedhong@google.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
AcKoucher
left a comment
AcKoucher
left a comment
There was a problem hiding this comment.
Looks okay to me.
In which context do you intend to use the custom reporting?
|
The check failure looks like some IT thing. I set the pipeline to run again. |
hongted
changed the title
maliberty
merged commit 20f11d7
into
The-OpenROAD-Project:master
3 participants
This will enable custom reporting of hpwl.