Skip to content

pdn: grid: limit via-repair shape extension to ring/domain boundary #10222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dnltz wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

pdn: grid: limit via-repair shape extension to ring/domain boundary #10222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/pdn/src/grid.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <cstdint>
#include <map>
#include <memory>
#include <optional>
#include <set>
#include <string>
#include <tuple>
Expand Down Expand Up @@ -313,6 +314,13 @@ bool Grid::repairVias(const Shape::ShapeTreeMap& global_shapes,
return !shape->belongsTo(this);
};

// When rings are present, shapes must not be extended beyond the ring
// boundary. Without this guard, extendTo() can push stripes through the
// padframe when a via sits right at the ring edge. For ring-less grids the
// obstruction-based check inside extendTo() is sufficient.
const std::optional<odb::Rect> allowed_area
= rings_.empty() ? std::nullopt : std::make_optional(getRingArea());

std::map<Shape*, std::unique_ptr<Shape>> replace_shapes;
for (const auto& via : vias_) {
// ensure shapes belong to something
Expand Down Expand Up @@ -345,7 +353,9 @@ bool Grid::repairVias(const Shape::ShapeTreeMap& global_shapes,
obstructions[extend_test->getLayer()],
lower_shape.get(),
obs_filter);
if (new_lower != nullptr) {
const bool lower_in_bounds
= !allowed_area || allowed_area->contains(new_lower->getRect());
if (new_lower != nullptr && lower_in_bounds) {
replace_shapes[lower_shape.get()] = std::move(new_lower);
}
}
Expand All @@ -361,7 +371,9 @@ bool Grid::repairVias(const Shape::ShapeTreeMap& global_shapes,
obstructions[extend_test->getLayer()],
upper_shape.get(),
obs_filter);
if (new_upper != nullptr) {
const bool upper_in_bounds
= !allowed_area || allowed_area->contains(new_upper->getRect());
if (new_upper != nullptr && upper_in_bounds) {
replace_shapes[upper_shape.get()] = std::move(new_upper);
}
}
Expand Down
Loading