Simplify tcl library initialization post switch to Tcl9#10227
Conversation
|
Setting as draft for now, so that we can watch the Tcl9 change from earlier soak for a while until we're confident to permanently switching to it and leave runfiles behind. |
hzeller
force-pushed
the
feature-20260422-no-tcl8
branch
from
113de20 to
e59fb2c
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes support for Tcl 8, simplifying the build system and the Tcl library initialization by exclusively using the Tcl 9 zipfs feature. The extract_zip rule, associated build configurations, and complex runfile-based initialization logic in tcl_library_init.cc have been deleted. Feedback suggests updating an outdated comment and returning the mount point as a constant string literal instead of retrieving it from the Tcl interpreter to improve clarity and robustness.
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
In tcl9, we don't need the runfiles anymore as we can use the embedded zipfs. Remove remants that were needed to provide runfile support. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260422-no-tcl8
branch
from
e59fb2c to
e2a4b6f
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Un-drafting. Looks like things are sufficiently soaked with Tcl9 working well. Time to simplify and get rid of the runfiles compatibility layer. |
2 participants
In tcl9, we don't need the runfiles anymore as we can use the embedded zipfs. Remove remants that were needed to provide runfile support.