Skip to content

Feature Web GUI#10234

Closed
openroad-ci wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:feature-Web-GUI
Closed

Feature Web GUI#10234
openroad-ci wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:feature-Web-GUI

Conversation

@openroad-ci

Copy link
Copy Markdown
Member

fix the issue #10232

@jorge-ferreira-pii

Copy link
Copy Markdown
Contributor

Support for 3DBlox Handling: We implemented the new clear3Dbx method, which properly iterates through and clears 3DBlox, allowing adequate support for multiple 3DBlox files during the same session.

Web GUI Closing and Shutdown: We wired the server shutdown mechanics to the reception of the exit/quit commands in the GUI's Tcl terminal, ensuring the actual and safe closure of the socket and the web session.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a clear_3dbx command and updates read_3dbx to automatically clear existing chip data before loading new files. It also modifies dbChip::destroy to include chip nets and implements a graceful server shutdown mechanism for the web interface triggered by 'exit' or 'quit' commands. Review feedback suggests using std::vector::assign for more idiomatic chip collection in C++ and recommends translating Portuguese UI strings to English to maintain consistency across the application.

Comment thread src/OpenRoad.cc Outdated
Comment on lines +504 to +507
std::vector<odb::dbChip*> chips;
for (odb::dbChip* chip : db_->getChips()) {
chips.push_back(chip);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use std::vector::assign with iterators to copy elements from a dbSet to a std::vector, as per the repository's general rules. This is more idiomatic and concise than a manual loop.

  std::vector<odb::dbChip*> chips;
  auto chips_set = db_->getChips();
  chips.assign(chips_set.begin(), chips_set.end());
References
  1. To copy elements from a dbSet to a std::vector, use the vector::assign() method with iterators from the dbSet, as direct assignment is not supported.

Comment thread src/web/src/main.js Outdated
Comment on lines +340 to +343
tclAppend('Sessão terminada. Pode fechar este separador.\n',
'tcl-exit');
input.disabled = true;
input.placeholder = 'Sessão terminada';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The UI strings are in Portuguese, while the rest of the application uses English. For consistency and maintainability, please use English for these messages.

Suggested change
tclAppend('Sessão terminada. Pode fechar este separador.\n',
'tcl-exit');
input.disabled = true;
input.placeholder = 'Sessão terminada';
tclAppend('Session terminated. You can close this tab.\n',
'tcl-exit');
input.disabled = true;
input.placeholder = 'Session terminated';

@jorge-ferreira-pii

Copy link
Copy Markdown
Contributor

@osamahammad21 FYI

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/web/src/web.cpp
}

Tcl_ResetResult(interp_);
logger_->info(utl::WEB, 5, "Server stopped.");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no header providing "Tcl_ResetResult" is directly included [misc-include-cleaner]

src/web/src/web.cpp:39:

- #include "tile_generator.h"
+ #include "tclDecls.h"
+ #include "tile_generator.h"

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/web/src/web.cpp
#include "request_handler.h"
#include "tcl.h"
#include "tclDecls.h"
#include "tile_generator.h"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: included header tclDecls.h is not used directly [misc-include-cleaner]

Suggested change
#include "tile_generator.h"
#include "tile_generator.h"

@jorge-ferreira-pii jorge-ferreira-pii removed the request for review from maliberty April 23, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants