Skip to content

web: mark field as no-spellcheck since commands are not words#10238

Merged
gadfort merged 2 commits into
The-OpenROAD-Project:masterfrom
gadfort:web-spellcheck
Apr 23, 2026
Merged

web: mark field as no-spellcheck since commands are not words#10238
gadfort merged 2 commits into
The-OpenROAD-Project:masterfrom
gadfort:web-spellcheck

Conversation

@gadfort

@gadfort gadfort commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Summary

No functional changes just prevents Chrome from generating a red line under all the commands.

Type of Change

  • Bug fix

Impact

N/A

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Related Issues

N/A

Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
@gadfort gadfort requested a review from maliberty April 23, 2026 13:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables spellchecking for the Tcl console input field. The reviewer suggests further disabling autocomplete, autocapitalize, and autocorrect to prevent browser interference with the custom console functionality and maintain command integrity.

Comment thread src/web/src/main.js Outdated
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
@gadfort gadfort enabled auto-merge April 23, 2026 15:09
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gadfort gadfort merged commit 19580ed into The-OpenROAD-Project:master Apr 23, 2026
16 checks passed
@gadfort gadfort deleted the web-spellcheck branch April 23, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants