rmp: mark aes_genetic regression test as size medium#10245
Merged
maliberty merged 1 commit intoApr 23, 2026
Merged
Conversation
The default "small" size exceeds its runtime budget under Bazel; bump aes_genetic to "medium" using the list + conditional pattern already used in src/rsz/test/BUILD. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test configuration in src/rmp/test/BUILD by introducing a MEDIUM_TESTS list and dynamically assigning the size attribute to regression_test targets, defaulting to small unless the test is explicitly listed as medium. I have no feedback to provide as no review comments were present.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 23, 2026
Member
|
Solves intermittent timeouts in the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
//src/rmp/test:aes_genetic-tcl_testfrom the default Bazel sizesmalltomediumso it no longer exceeds thesmallruntime budget.The change mirrors the list + conditional pattern already used in
src/rsz/test/BUILD(BIG_TESTS): a newMEDIUM_TESTSlist insrc/rmp/test/BUILD, and a conditionalsize = "medium" if test_name in MEDIUM_TESTS else "small"on theregression_testcall. All otherrmpregression tests remain atsmall.Type of Change
Impact
No functional change to the test content; only the Bazel
sizeattribute foraes_geneticchanges, giving it the largermediumtimeout/resource budget.Verification
./etc/Build.sh).```
bazelisk query 'attr(size, medium, //src/rmp/test:aes_genetic-tcl_test)'
-> //src/rmp/test:aes_genetic-tcl_test
```
Related Issues
N/A