clang-tidy: don't use modernize-use-constraints#10250
Merged
maliberty merged 1 commit intoApr 29, 2026
Merged
Conversation
This check crashes `clang-tidy` on some files and with the changes in The-OpenROAD-Project#10185, that takes down the whole run-clang-tidy-cached.cc. Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
I've never observed this myself or in the CI. What version/platform are you observing this with? |
Collaborator
Author
|
using the |
Collaborator
Author
|
I still can't run the general clang-tidy because of the Given that we're not interested in using constraints anyway at this point, removing the buggy clang-tidy check looks like a good choice. |
maliberty
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check crashes
clang-tidyon some files andwith the changes in #10185, that takes down the whole run-clang-tidy-cached.cc.