test/orfs: use /usr/bin/env bash in check_same.sh shebang#10320
Merged
maliberty merged 1 commit intoMay 4, 2026
Conversation
/bin/bash is not a guaranteed location (e.g. NixOS does not provide it); use /usr/bin/env bash for portability. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the shebang in test/orfs/check_same.sh from #!/bin/bash to #!/usr/bin/env bash to improve script portability across different environments. I have no feedback to provide as there were no review comments to evaluate.
Merged
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
hzeller
approved these changes
May 3, 2026
maliberty
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#!/bin/bashwith#!/usr/bin/env bashintest/orfs/check_same.sh./bin/bashis not a guaranteed location (e.g. NixOS does not ship it there);/usr/bin/env bashworks on NixOS as well as conventional FHS distros.I also did a sweep of the rest of the
.shfiles in the tree —check_same.shis the only one that hard-codes/bin/bash. The remaining shebangs are/usr/bin/env bashor/bin/sh(POSIX-required, present on NixOS).Spotted in #10237 (comment).
Test plan