From 32a33b798881013b67fe67ce8beaa9085f3ff36f Mon Sep 17 00:00:00 2001 From: Henner Zeller Date: Thu, 18 Jun 2026 15:40:25 +0200 Subject: [PATCH] Mark non-hermetic targets 'manual'. They can only run on special machines that have the binaries `git` (for the format tests) or `make` installed AND with their bazel configured to actually look in the path. These targets currently will fail on strict systems (such as NixOS), so make the whole process painful. To fix, the binaries either should be replaced with simpler processes (e.g. why use `make` if we have bazel), or commpiled as part of a bazel dependency. Makes #10311 slightly less painful by not failing in globbing mode. Signed-off-by: Henner Zeller --- BUILD.bazel | 21 +++++++++++++++++---- docs/BUILD.bazel | 1 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/BUILD.bazel b/BUILD.bazel index 564da02b8a6..582d80c588c 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -555,7 +555,10 @@ sh_test( "tclint.toml", "//bazel:tclint", ], - tags = ["local"], + tags = [ + "local", + "manual", + ], ) # --- TCL formatting check (tclfmt --check) -------------------------------- @@ -569,7 +572,10 @@ sh_test( "tclint.toml", "//bazel:tclfmt", ], - tags = ["local"], + tags = [ + "local", + "manual", + ], ) # --- TCL auto-format only (tclfmt --in-place) ----------------------------- @@ -596,7 +602,10 @@ sh_test( "MODULE.bazel", "@buildifier_prebuilt//:buildifier", ], - tags = ["local"], + tags = [ + "local", + "manual", + ], ) # --- Bazel formatting check (buildifier -mode=check -lint=off) ------------ @@ -610,7 +619,10 @@ sh_test( "MODULE.bazel", "@buildifier_prebuilt//:buildifier", ], - tags = ["local"], + tags = [ + "local", + "manual", + ], ) # --- Bazel auto-format only (buildifier -mode=fix) ------------------------ @@ -629,6 +641,7 @@ sh_binary( test_suite( name = "lint_test", + tags = ["manual"], tests = [ ":fmt_bzl_test", ":fmt_tcl_test", diff --git a/docs/BUILD.bazel b/docs/BUILD.bazel index cc909308600..f17bf2c6469 100644 --- a/docs/BUILD.bazel +++ b/docs/BUILD.bazel @@ -67,5 +67,6 @@ man_pages( "//docs/src/scripts:manpage.py", "//docs/src/scripts:extract_utils.py", ], + tags = ["manual"], visibility = ["//visibility:public"], )