Document more layering-check issues.#10693
Merged
maliberty merged 1 commit intoJun 26, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the "layering_check" feature across multiple Bazel packages to enforce strict header dependency checks, while disabling it for a specific C++ library that relies on private headers. The review feedback correctly points out that enabling "layering_check" in packages containing only Python targets or filegroups is redundant, as it is a C++ compilation check.
Member
|
gemini comments seem relevant |
Member
|
@hzeller ping? |
hzeller
force-pushed
the
feature-20260619-doc-layering
branch
from
0f9c854 to
266e213
Compare
Collaborator
Author
|
Removed the layering check from the packages for now, but it also makes it easier to forget later once the first cc_library is added... |
Member
|
why is sta updated in this PR? |
Add the layering check to BUILD files that miss it, then explicitly switch it off for libraries with issues. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260619-doc-layering
branch
from
266e213 to
f409d33
Compare
Collaborator
Author
|
looks like sta was updated in-between, and I didn't pick it up when rebasing. Fixed. |
maliberty
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the layering check to BUILD files that miss it, then explicitly switch it off for libraries with issues.