Fix parallel test race condition in PDN tests#10754
Merged
maliberty merged 1 commit intoJun 25, 2026
Merged
Conversation
Signed-off-by: Drew Lewis <cannada@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test script core_grid_with_M6_min_area_rule.tcl to use the correct result file name core_grid_with_M6_min_area_rule.def instead of core_grid_with_M6_min_area.def. There are no review comments, and I have no feedback to provide.
Collaborator
Author
|
Error looked like: |
maliberty
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this issue earlier today in a different PR, https://jenkins.openroad.tools/job/OpenROAD-Public/job/PR-10642-merge/14/stages/
Pretty sure that both the core_grid_with_M6_min_area and core_grid_with_M6_min_area_rule tests were configured to write their temporary runtime DEF output to the exact same filename: core_grid_with_M6_min_area-tcl.def inside the src/pdn/test/results/ directory.
Which caused a race condition and caused the test to fail during the file close/rename stage, throwing a
filesystem error: cannot rename: No such file or directory error.I think we can fix it by changing the name of one of the output files.