-
Notifications
You must be signed in to change notification settings - Fork 961
docs: make //docs:man_pages hermetic by managing pandoc via Bazel #10764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luarss
wants to merge
5
commits into
The-OpenROAD-Project:master
Choose a base branch
from
luarss:fix/issue-10692-hermetic-manpages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1d373fa
docs: make //docs:man_pages hermetic by managing pandoc via Bazel
luarss ac7d50e
chore(docs): add build_test and remove dead bazel-manpages target
luarss 7403801
docs: add missing docstrings and fix comments in manpage bazel files
luarss 34b2e9c
fix lints
luarss c90323d
retrigger CI
luarss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these root-module
http_archiverepos changes Bzlmod state, butMODULE.bazel.lockwas not updated (it has nopandoc_*repo specs). The PR CI workflow.github/workflows/github-actions-check-bazel-lock.ymlrunsbazelisk mod deps --lockfile_mode=error; Bazel's CLI reference describeserrormode as using the lockfile but throwing if it is not up to date, so this will fail before//docs:man_pagesis built. Please runbazelisk mod deps --lockfile_mode=updateand commit the lockfile.Useful? React with 👍 / 👎.