rcx: fix deadcode coverity issue#10945
Open
AcKoucher wants to merge 2 commits into
Open
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors extMain::run in src/rcx/src/netRC.cpp by replacing the local variable debugNetId with the member variable _debug_net_id and correcting the format specifier in sprintf to %u for the unsigned net ID. Feedback suggests replacing the unsafe sprintf call with std::to_string to prevent potential buffer overflow vulnerabilities and simplify the code.
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From the original code.
Type of Change
Impact
Debug net option should work now.
Verification
./etc/Build.sh).