drt: use odb layer range instead of own options to define layers by eder-matheus · Pull Request #7909 · The-OpenROAD-Project/OpenROAD

eder-matheus · 2025-07-28T17:17:58Z

Fixes #7858.

I've decided to remove the outdated options, but I can revert it and make them deprecated if it's preferable.

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

github-actions · 2025-07-28T17:29:40Z

clang-tidy review says "All clean, LGTM! 👍"

maliberty · 2025-07-28T17:41:17Z

@osamahammad21 please handle the review

osamahammad21

Looks fine to me. I prefer having them deprecated with an error so that the user knows this is not the way we set the routing layer range anymore and update their script. Just temporarily until all flows are updated. This change should be in a separate commit that could be reverted in the future.

While I was looking at the set_routing_layers command under odb I found that it calls a command in grt. Is there an actual dependency on GRT or could we just make it pure odb?

OpenROAD/src/odb/src/swig/tcl/odb.tcl

Lines 584 to 588 in a5a2094

    
           proc define_layer_range { layers } { 
        
             set layer_range [grt::parse_layer_range "-layers" $layers] 
        
             lassign $layer_range min_layer max_layer 
        
             grt::check_routing_layer $min_layer 
        
             grt::check_routing_layer $max_layer

eder-matheus · 2025-07-28T17:47:09Z

While I was looking at the set_routing_layers command under odb I found that it calls a command in grt. Is there an actual dependency on GRT or could we just make it pure odb?

I don't think we have a real dependency with GRT. I can update the command in another PR to make it pure ODB.

osamahammad21 · 2025-07-28T17:51:24Z

While I was looking at the set_routing_layers command under odb I found that it calls a command in grt. Is there an actual dependency on GRT or could we just make it pure odb?

I don't think we have a real dependency with GRT. I can update the command in another PR to make it pure ODB.

Great, then we will handle this in a separate PR. I will change my review to "Request changes" until the deprecation is added.

osamahammad21

Deprecation

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

…ROAD into drt_layer_range

osamahammad21

I'll leave fixing the format and merging to you.

github-actions · 2025-07-28T20:43:22Z

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

github-actions · 2025-07-28T21:21:19Z

clang-tidy review says "All clean, LGTM! 👍"

…ROAD into drt_layer_range

github-actions · 2025-07-29T14:38:32Z

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

…ROAD into drt_layer_range

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

github-actions · 2025-07-29T18:43:33Z

clang-tidy review says "All clean, LGTM! 👍"

oharboe · 2025-07-30T05:34:32Z

#7921

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

github-actions · 2025-07-30T19:22:21Z

clang-tidy review says "All clean, LGTM! 👍"

osamahammad21 · 2025-07-30T19:22:18Z

      set rhost $keys(-remote_host)
    } else {
-      utl::error DRT 506 "-remote_host is required for distributed routing."
+      utl::warn DRT 506 "-remote_host is required for distributed routing."


Bazel build is breaking because of this error, since ORFS still uses these options. I'll turn them back into a error after updating ORFS (The-OpenROAD-Project/OpenROAD-flow-scripts#3362)

https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/docs/user/Bazel-breaking-changes.md

This reverts commit bd9b7d9. Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

github-actions · 2025-07-30T20:19:54Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2025-07-30T20:22:05Z

clang-tidy review says "All clean, LGTM! 👍"

This PR updates OpenROAD to include some important bug fixes and improvements. API breakages in OpenROAD are: - a number of procs were moved from `rsz` into the new `est` - drt doesn't define its own layer range anymore: The-OpenROAD-Project/OpenROAD#7909 - `random` in `place_pins` has been removed --------- Signed-off-by: Leo Moser <leomoser99@gmail.com>

eder-matheus added 6 commits July 28, 2025 13:04

drt: remove -bottom_routing_layer and -top_routing_layer options

421a737

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

drt: get layer range from odb

cfdbdbb

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

drt: update unit tests to use the set_routing_layers command

5045a0d

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

test: remove outdated drt options

9c22907

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: remove outdated drt options

753ac53

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

drt: clang-format

5563683

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

eder-matheus requested review from maliberty and osamahammad21 and removed request for maliberty July 28, 2025 17:18

maliberty removed their request for review July 28, 2025 17:41

osamahammad21 approved these changes Jul 28, 2025

View reviewed changes

osamahammad21 requested changes Jul 28, 2025

View reviewed changes

eder-matheus added 2 commits July 28, 2025 16:29

drt: add deprecated messages

ad31773

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

Merge branch 'master' of https://github.com/The-OpenROAD-Project/Open…

d80a5b0

…ROAD into drt_layer_range

osamahammad21 approved these changes Jul 28, 2025

View reviewed changes

eder-matheus added 2 commits July 28, 2025 18:06

drt: tclfmt

ae085f9

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt/drt: py format

76922a8

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

Merge branch 'master' of https://github.com/The-OpenROAD-Project/Open…

b86be75

…ROAD into drt_layer_range

eder-matheus added 3 commits July 29, 2025 15:28

drt: udpate readme

deadef3

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

Merge branch 'master' of https://github.com/The-OpenROAD-Project/Open…

5e0546b

…ROAD into drt_layer_range

rcx: update ok file

4fa5910

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

eder-matheus mentioned this pull request Jul 29, 2025

remove deprecated drt layer range options The-OpenROAD-Project/OpenROAD-flow-scripts#3362

Merged

eder-matheus added 2 commits July 30, 2025 16:04

Merge branch 'master' into drt_layer_range

ad3aed0

drt: error -> warn until ORFS is updated

bd9b7d9

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

osamahammad21 reviewed Jul 30, 2025

View reviewed changes

eder-matheus added 2 commits July 30, 2025 17:10

Revert "drt: error -> warn until ORFS is updated"

817209a

This reverts commit bd9b7d9. Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

drt: error -> warn until ORFS is updated on the correct messages

7f693eb

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

eder-matheus force-pushed the drt_layer_range branch from 6594d7b to 7f693eb Compare July 30, 2025 20:11

eder-matheus merged commit 13839d9 into The-OpenROAD-Project:master Jul 30, 2025
11 checks passed

eder-matheus deleted the drt_layer_range branch July 31, 2025 16:52

mole99 mentioned this pull request Sep 1, 2025

feat: update openroad, opensta and openroad-abc librelane/librelane#757

Merged

4 tasks

	proc define_layer_range { layers } {
	set layer_range [grt::parse_layer_range "-layers" $layers]
	lassign $layer_range min_layer max_layer
	grt::check_routing_layer $min_layer
	grt::check_routing_layer $max_layer

Uh oh!

Conversation

eder-matheus commented Jul 28, 2025

Uh oh!

github-actions Bot commented Jul 28, 2025

Uh oh!

maliberty commented Jul 28, 2025

Uh oh!

osamahammad21 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eder-matheus commented Jul 28, 2025

Uh oh!

osamahammad21 commented Jul 28, 2025

Uh oh!

osamahammad21 left a comment

Choose a reason for hiding this comment

Uh oh!

osamahammad21 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 28, 2025

Uh oh!

github-actions Bot commented Jul 28, 2025

Uh oh!

github-actions Bot commented Jul 29, 2025

Uh oh!

github-actions Bot commented Jul 29, 2025

Uh oh!

oharboe commented Jul 30, 2025

Uh oh!

github-actions Bot commented Jul 30, 2025

Uh oh!

osamahammad21 Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

eder-matheus Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

oharboe Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 30, 2025

Uh oh!

github-actions Bot commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

osamahammad21 left a comment •

edited

Loading