Cts fix improve automatic clustering#9637

Merged

maliberty merged 50 commits into

The-OpenROAD-Project:masterfrom

luis201420:cts_fix_improve_clustering

May 1, 2026

luis201420 commented Mar 5, 2026

Contributor

Fixes #8540

This includes reverted modifications of PR #8949

Additionally, modifications are included to use buffer max cap when performing macro clustering, which corrects the error caused by the PR revert.

luis201420 added 9 commits

February 25, 2026 03:23


          Revert "Merge pull request The-OpenROAD-Project#9029 from eder-matheu…

f6ff33a

…s/revert_cts"

This reverts commit b139056, reversing
changes made to 20d9928.

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          cts: use buffer max cap in macro clustering

d561944

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          cts: Fix variable name missed during revert

85248b4

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

fc9bbab

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

fe3ea35

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

527288b

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

dc5c1c1

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

711d6d9

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          cts: update unit test

af95cf1

Signed-off-by: luis201420 <luisemv@precisioninno.com>

luis201420 requested a review from arthurjolo

March 5, 2026 02:37

gemini-code-assist Bot reviewed

View reviewed changes

gemini-code-assist Bot left a comment

Contributor

Code Review

This pull request refactors the automatic clustering logic in CTS. It simplifies the options by removing the ability to sweep through multiple cluster sizes and diameters. Instead, it introduces a new automatic mode where clustering is based on buffer max capacitance if the user does not specify both a cluster size and a max diameter. The changes in CtsOptions, HTreeBuilder, and SinkClustering are consistent with this new approach. I've added a couple of suggestions to improve code conciseness and readability.

_{Note: Security Review did not run due to the size of the PR.}

src/cts/src/SinkClustering.cpp Outdated

github-actions Bot commented Mar 5, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 4 commits

March 10, 2026 02:43


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

3aa83c6

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

4fe28a6

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

d1f91b6

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          dbSta: update unit tests

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Mar 16, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 2 commits

March 18, 2026 00:06


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

fe89716

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

dd6d360

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Mar 18, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 2 commits

March 18, 2026 17:05


          update unit tests

1303f48

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          cts: add suggested modifications to improve readability

949ac02

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Mar 18, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment

github-actions Bot commented Mar 18, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 2 commits

March 21, 2026 00:13


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

86737a8

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

f631b4f

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Mar 23, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 2 commits

March 24, 2026 05:05


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

8032fa2

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

b156bfe

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Mar 25, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

f8d5fc0

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Apr 16, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 2 commits

April 20, 2026 02:08


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

43647c1

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

d8a3150

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Apr 21, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 5 commits

April 21, 2026 16:10


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

4788a64

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

c44d51b

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

231cc36

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          cts: update unit tests

41a954a

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          update unit tests

092643d

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Apr 23, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 2 commits

April 24, 2026 22:17


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

097a090

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          update unit tests

a982840

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Apr 24, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 3 commits

April 27, 2026 18:20


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

7d697eb

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

e5e9bc0

Signed-off-by: luis201420 <luisemv@precisioninno.com>


          update unit test

ebd7c1e

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Apr 28, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"


          rsz: update unit test

6fdc816

Signed-off-by: luis201420 <luisemv@precisioninno.com>

luis201420 requested a review from precisionmoon

April 28, 2026 23:05

github-actions Bot commented Apr 28, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 commented Apr 28, 2026

Contributor Author

I created a PR The-OpenROAD-Project/OpenROAD-flow-scripts#4196 to update the metrics.


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

0b6ac17

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Apr 29, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

luis201420 mentioned this pull request

Update metrics to fix clustering on CTS The-OpenROAD-Project/OpenROAD-flow-scripts#4196

Closed


          Merge remote-tracking branch 'origin' into cts_fix_improve_clustering

399989e

Signed-off-by: luis201420 <luisemv@precisioninno.com>

github-actions Bot commented Apr 30, 2026

Contributor

clang-tidy review says "All clean, LGTM! 👍"

maliberty approved these changes

View reviewed changes

maliberty merged commit df15ee7 into The-OpenROAD-Project:master

16 checks passed

luis201420 deleted the cts_fix_improve_clustering branch

May 4, 2026 16:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels