Merge pull request #348 from The-OpenROAD-Project-staging/sta_latest_from_parallaxsw_tidy_0416

Sta latest from parallaxsw tidy 0416

Author: maliberty

.clang-tidy

@@ -0,0 +1,80 @@
+Checks: >
+  clang-diagnostic-*,
+  clang-analyzer-*,
+  -clang-analyzer-core.NonNullParamChecker,
+  -clang-analyzer-core.CallAndMessage,
+  -clang-analyzer-core.uninitialized.UndefReturn,
+  -clang-analyzer-cplusplus.NewDeleteLeaks,
+  -clang-analyzer-optin.performance.Padding,
+  readability-*,
+  -readability-identifier-naming,
+  -readability-braces-around-statements,
+  -readability-convert-member-functions-to-static,
+  -readability-else-after-return,
+  -readability-function-cognitive-complexity,
+  -readability-inconsistent-ifelse-braces,
+  -readability-identifier-length,
+  -readability-implicit-bool-conversion,
+  -readability-isolate-declaration,
+  -readability-magic-numbers,
+  -readability-make-member-function-const,
+  -readability-math-missing-parentheses,
+  -readability-named-parameter,
+  -readability-qualified-auto,
+  -readability-redundant-access-specifiers,
+  -readability-simplify-boolean-expr,
+  -readability-static-definition-in-anonymous-namespace,
+  -readability-suspicious-call-argument,
+  -readability-uppercase-literal-suffix,
+  -readability-use-anyofallof,
+  google-*,
+  -google-readability-avoid-underscore-in-googletest-name,
+  -google-readability-braces-around-statements,
+  -google-readability-casting,
+  -google-readability-todo,
+  -google-runtime-references,
+  -google-explicit-constructor,
+  performance-*,
+  -performance-enum-size,
+  bugprone-*,
+  -bugprone-branch-clone,
+  -bugprone-easily-swappable-parameters,
+  -bugprone-exception-escape,
+  -bugprone-macro-parentheses,
+  -bugprone-move-forwarding-reference,
+  -bugprone-narrowing-conversions,
+  -bugprone-suspicious-missing-comma,
+  -bugprone-throwing-static-initialization,
+  modernize-*,
+  -modernize-avoid-bind,
+  -modernize-avoid-c-arrays,
+  -modernize-concat-nested-namespaces,
+  -modernize-macro-to-enum,
+  -modernize-pass-by-value,
+  -modernize-raw-string-literal,
+  -modernize-return-braced-init-list,
+  -modernize-use-auto,
+  -modernize-use-nodiscard,
+  -modernize-use-trailing-return-type,
+  -modernize-use-transparent-functors,
+  misc-*,
+  -misc-const-correctness,
+  -misc-multiple-inheritance,
+  -misc-no-recursion,
+  -misc-non-private-member-variables-in-classes,
+  -misc-redundant-expression,
+  -misc-unused-parameters,
+  -misc-use-anonymous-namespace,
+  -misc-use-internal-linkage,
+  -misc-include-cleaner
+
+# Only report diagnostics in headers under this tree (app/, include/sta/, build-generated
+# headers, etc.).
+# Excludes system and third-party paths such as /opt/local/include.
+HeaderFilterRegex: '.*/(app|cmake|dcalc|graph|liberty|network|parasitics|power|sdc|sdf|search|spice|tcl|util|verilog|include/sta|build/include/sta)/.*'
+
+# util/gzstream.hh
+# util/FlexDisableRegister.hh
+# Bison-generated parser headers (build/{Liberty,Verilog,...}Parse.hh)
+ExcludeHeaderFilterRegex: '(.*/)?(gzstream\.hh|FlexDisableRegister\.hh|(Liberty|Verilog|Sdf|Spef|Saif|LibExpr)Parse\.hh)$'
+FormatStyle: none

.cursor/rules/cpp-coding-standards.mdc

@@ -31,3 +31,29 @@ alwaysApply: false
 
 - C++ source: `.cc`
 - C++ headers: `.hh`
+
+## Include order
+
+Sort `#include` lines **lexicographically by the path inside** `<>`
+or `""` (case-sensitive). Separate **groups** with a single blank line.
+
+### Translation units (`*.cc`)
+
+1. **Primary header(s)** for this file only:
+   - `#include "Stem.hh"` where `Stem` matches the basename of the `.cc` file (e.g. `Foo.cc` → `Foo.hh`).
+   - If the file uses a paired private header, include `#include "StemPvt.hh"` **immediately after** `Stem.hh` (e.g. `MakeTimingModel.cc` → `MakeTimingModel.hh` then `MakeTimingModelPvt.hh`).
+   - Do **not** pull in other headers just because their names share a prefix with `Stem` (e.g. `SearchClass.hh` is not a “primary” include for `Search.cc`; it belongs in the project group below).
+
+2. **System / standard library** headers: `#include <...>` lines, sorted alphabetically.
+
+3. **All other project** headers: `#include "..."` lines, sorted alphabetically (including `search/Crpr.hh`-style paths and includes from `liberty/`, etc.).
+
+If a **comment or special block** intentionally splits the include list (e.g. a third-party note before `#include "cudd.h"`), keep that structure; sort only within each contiguous run of `#include` lines unless merging groups is clearly safe.
+
+### Headers (`*.hh`)
+
+After `#pragma once` (and the file’s license block, if present):
+
+1. **System** `#include <...>` lines, sorted alphabetically.
+
+2. **Project** `#include "..."` lines, sorted alphabetically.

.github/workflows/ci.yml

@@ -54,6 +54,7 @@ jobs:
           name: artifact
           path: |
             build/install/*
+          retention-days: 1
 
       - name: Upload Test Result
         uses: actions/upload-artifact@v7

CMakeLists.txt

@@ -1,5 +1,5 @@
 # OpenSTA, Static Timing Analyzer
-# Copyright (c) 2025, Parallax Software, Inc.
+# Copyright (c) 2026, Parallax Software, Inc.
 # 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -222,7 +222,6 @@ set(STA_SOURCE
   util/Error.cc
   util/Fuzzy.cc
   util/Hash.cc
-  util/Machine.cc
   util/MinMax.cc
   util/PatternMatch.cc
   util/Report.cc
@@ -239,6 +238,16 @@ set(STA_SOURCE
   verilog/VerilogWriter.cc
   )
 
+if(APPLE)
+  list(APPEND STA_SOURCE util/MachineApple.cc)
+elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux")
+  list(APPEND STA_SOURCE util/MachineLinux.cc)
+elseif(WIN32)
+  list(APPEND STA_SOURCE util/MachineWin32.cc)
+else()
+  list(APPEND STA_SOURCE util/MachineUnknown.cc)
+endif()
+
 # Source files.
 set(STA_TCL_FILES
   tcl/Init.tcl

app/StaMain.cc

@@ -148,4 +148,4 @@ unencode(const char *inits[])
   return unencoded;
 }
 
-} // namespace
+} // namespace sta

cmake/FindTCL.cmake

@@ -23,6 +23,7 @@
 # searching OSX system directories before unix directories.
 
 set(TCL_POSSIBLE_NAMES
+  #tcl90 tcl9.0
   tcl87 tcl8.7
   tcl86 tcl8.6
   tcl85 tcl8.5
@@ -32,6 +33,7 @@ set(TCL_POSSIBLE_NAMES
 if (NOT TCL_LIB_PATHS)
   if (CMAKE_SYSTEM_NAME STREQUAL "Darwin")
     set(TCL_LIB_PATHS
+      #/opt/homebrew/Cellar/tcl-tk/9.0.3/lib
       /opt/homebrew/Cellar/tcl-tk@8/8.6.17/lib
       /opt/homebrew/Cellar/tcl-tk@8/8.6.16/lib
       /opt/homebrew/opt/tcl-tk/lib /usr/local/lib)

dcalc/ArcDcalcWaveforms.cc

@@ -22,16 +22,16 @@
 // 
 // This notice may not be removed or altered from any source distribution.
 
-#include <memory>
-
 #include "ArcDcalcWaveforms.hh"
 
-#include "Report.hh"
-#include "Liberty.hh"
-#include "Network.hh"
-#include "Graph.hh"
+#include <memory>
+
 #include "ArcDelayCalc.hh"
+#include "Graph.hh"
 #include "GraphDelayCalc.hh"
+#include "Liberty.hh"
+#include "Network.hh"
+#include "Report.hh"
 
 namespace sta {
 
@@ -83,4 +83,4 @@ ArcDcalcWaveforms::inputWaveform(ArcDcalcArg &dcalc_arg,
   return Waveform();
 }
 
-} // namespace
+} // namespace sta

dcalc/ArcDcalcWaveforms.hh

@@ -51,5 +51,5 @@ protected:
                          const StaState *sta);
 };
 
-} // namespace
+} // namespace sta
 

dcalc/ArcDelayCalc.cc

@@ -27,12 +27,12 @@
 #include <cstdlib>
 #include <string>
 
-#include "StringUtil.hh"
-#include "Units.hh"
+#include "Graph.hh"
 #include "Liberty.hh"
-#include "TimingArc.hh"
 #include "Network.hh"
-#include "Graph.hh"
+#include "StringUtil.hh"
+#include "TimingArc.hh"
+#include "Units.hh"
 
 namespace sta {
 
@@ -135,7 +135,7 @@ ArcDcalcArg::ArcDcalcArg(const Pin *in_pin,
                          const Pin *drvr_pin,
                          Edge *edge,
                          const TimingArc *arc,
-                         const Slew in_slew,
+                         Slew in_slew,
                          float load_cap,
                          const Parasitic *parasitic) :
   in_pin_(in_pin),
@@ -165,17 +165,7 @@ ArcDcalcArg::ArcDcalcArg(const Pin *in_pin,
 {
 }
 
-ArcDcalcArg::ArcDcalcArg(const ArcDcalcArg &arg) :
-  in_pin_(arg.in_pin_),
-  drvr_pin_(arg.drvr_pin_),
-  edge_(arg.edge_),
-  arc_(arg.arc_),
-  in_slew_(arg.in_slew_),
-  load_cap_(arg.load_cap_),
-  parasitic_(arg.parasitic_),
-  input_delay_(arg.input_delay_)
-{
-}
+ArcDcalcArg::ArcDcalcArg(const ArcDcalcArg &arg) = default;
 
 const RiseFall *
 ArcDcalcArg::inEdge() const
@@ -305,4 +295,4 @@ ArcDcalcResult::setLoadSlew(size_t load_idx,
   load_slews_[load_idx] = load_slew;
 }
 
-} // namespace
+} // namespace sta

dcalc/Arnoldi.hh

@@ -45,7 +45,7 @@ class arnoldi1
 public:
   arnoldi1() { order=0; n=0; d=nullptr; e=nullptr; U=nullptr; ctot=0.0; sqc=0.0; }
   ~arnoldi1();
-  double elmore(int term_index);
+  double elmore(int k);
 
   //
   // calculate poles/residues for given rdrive
@@ -70,12 +70,12 @@ class rcmodel : public ConcreteParasitic,
 {
 public:
   rcmodel();
-  virtual ~rcmodel();
-  virtual float capacitance() const;
-  virtual PinSet unannotatedLoads(const Pin *drvr_pin,
-                                  const Parasitics *parasitics) const;
+  ~rcmodel() override;
+  float capacitance() const override;
+  PinSet unannotatedLoads(const Pin *drvr_pin,
+                          const Parasitics *parasitics) const override;
 
-  const Pin **pinV; // [n]
+  const Pin **pinV{nullptr}; // [n]
 };
 
 struct timing_table
@@ -86,4 +86,4 @@ struct timing_table
   float in_slew;
 };
 
-} // namespace
+} // namespace sta