fix: guard parseBusName against non-numeric bus subscripts#339
Merged
maliberty merged 1 commit intoApr 6, 2026
Merged
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
maliberty
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Reading a DEF with port names containing non-numeric bracket subscripts (e.g., kv_write[3][write_en]) crashes with a segfault. parseBusName uses rfind('[') to find the last left bracket, then calls std::stoi on the content. For kv_write[3][write_en], rfind finds the [ before write_en, and stoi("write_en]") throws an unhandled std::invalid_argument which terminates the process.
This occurs when externally-produced DEF files use multi-level bracket names where the innermost subscript is a field name rather than a numeric bus index.
Fix:
Add an isdigit check on the first character after [ before calling stoi in both parseBusName overloads. Non-numeric subscripts like [write_en] are treated as non-bus names (is_bus = false), while ports with numeric trailing subscripts like kv_write[3][ write_entry][4] continue to parse and group correctly as bus kv_write[3][write_entry] with index 4.