On bazel: use readline set-up provided by OpenROAD#341
Merged
maliberty merged 1 commit intoApr 17, 2026
Merged
Conversation
hzeller
added a commit
to hzeller/OpenROAD
that referenced
this pull request
Apr 7, 2026
Thus, it can use it as prepared in The-OpenROAD-Project/OpenSTA#341 Signed-off-by: Henner Zeller <h.zeller@acm.org>
Contributor
|
Can you please check why OpenROAD Bazel RunTests are failing? Maybe you have to pick up my changes from latest OpenROAD master to verify |
hzeller
force-pushed
the
feature-20260407-use-or-readline
branch
from
33d5898 to
8b18c8c
Compare
The bazel compile always happens as submodule in OpenROAD, so we can use the same mechanism provided there to set up the readline library. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260407-use-or-readline
branch
from
8b18c8c to
fcc5a3e
Compare
Contributor
Author
|
CI glitch unrelated: can't connect to ubuntu. |
maliberty
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bazel compile always happens as submodule in OpenROAD, so we can use the same mechanism provided there to set up the readline library.