Sta latest upstream primacrashfix 0413#347
Merged
maliberty merged 11 commits intoApr 16, 2026
Merged
Conversation
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
…m upstream Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
…ome coverity fix but still problematic Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
…age RC vals in report_dcalc Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
…t PrimaDcalc Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
|
|
4 tasks
| if (arg_fail) { | ||
| const RiseFall *rf = arc->toEdge()->asRiseFall(); | ||
| const Parasitic *reduced = | ||
| table_dcalc_->findParasitic(drvr_pin, rf, scene, min_max); |
Contributor
There was a problem hiding this comment.
@maliberty This is the change I added extra from Parallaxsw/OSTA as otherwise we get veri weird Rpi values of parasitics in report_dcalc if we requested PRIMA delay calc with a library with no CCS delay models. I will change this if upstream has an alternate solution
maliberty
previously approved these changes
Apr 15, 2026
Member
|
|
…ey don't collide with op from sdc_exception_override_priority.tcl Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
maliberty
approved these changes
Apr 16, 2026
maliberty
merged commit f668dba
into
The-OpenROAD-Project:master
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue still existed after taking latest changes from upstream handling Prima dcalc issue. So I resolved it
Three things change together, all from the same cause — the call now goes through DmpCeff instead of calling GateTableModel directly:
The new values are the more accurate NLDM+Elmore-reduction answer; the old goldens were baking in a slightly pessimistic number that fell out of the pre-b136ba30 code path's quirk of using raw load_cap for the table lookup.