Skip to content

Sta latest from parallaxsw tidy 0416#349

Merged
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:sta_latest_from_parallaxsw_tidy_0416
Apr 20, 2026
Merged

Sta latest from parallaxsw tidy 0416#349
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:sta_latest_from_parallaxsw_tidy_0416

Conversation

@openroad-ci

Copy link
Copy Markdown
Member
  1. Removed "util/Machine.cc" from srcs (file deleted upstream).
  2. Removed the 6-line commented-out select() block (dead code).
  3. Replaced with a live select() on srcs covering all four platforms — mirrors CMakeLists.txt:241-249 exactly:
    - @platforms//os:osx → MachineApple.cc
    - @platforms//os:linux → MachineLinux.cc
    - @platforms//os:windows → MachineWin32.cc
    - //conditions:default → MachineUnknown.cc
  4. Removed the textual_hdrs block that (wrongly) listed the platform files as text-include headers.

Net effect: Bazel should now compile exactly one platform-specific .cc into libOpenSTA.a, matching CMake. The previous Linux CI wasn't caught because macOS CI is the first to exercise a different branch of the
broken textual_hdrs select — but both platforms had the same underlying problem (nothing was actually compiled, only exposed as includable text for the missing dispatcher).

@dsengupta0628

Copy link
Copy Markdown
Contributor

fixes macOS build issue as seen in OpenROAD: The-OpenROAD-Project/OpenROAD#10206

@dsengupta0628 dsengupta0628 requested a review from maliberty April 20, 2026 18:24
@maliberty maliberty merged commit 8e42af1 into The-OpenROAD-Project:master Apr 20, 2026
6 of 7 checks passed
@openroad-ci openroad-ci deleted the sta_latest_from_parallaxsw_tidy_0416 branch April 20, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants