Sta latest from parallaxsw tidy 0416#349
Merged
maliberty merged 2 commits intoApr 20, 2026
Merged
Conversation
…that controlled dispatch Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
4 tasks
Contributor
|
fixes macOS build issue as seen in OpenROAD: The-OpenROAD-Project/OpenROAD#10206 |
maliberty
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- @platforms//os:osx → MachineApple.cc
- @platforms//os:linux → MachineLinux.cc
- @platforms//os:windows → MachineWin32.cc
- //conditions:default → MachineUnknown.cc
Net effect: Bazel should now compile exactly one platform-specific .cc into libOpenSTA.a, matching CMake. The previous Linux CI wasn't caught because macOS CI is the first to exercise a different branch of the
broken textual_hdrs select — but both platforms had the same underlying problem (nothing was actually compiled, only exposed as includable text for the missing dispatcher).