Adds stream interface for parseLibertyFile and readLibertyFile#375
Open
hongted wants to merge 2 commits into
Open
Adds stream interface for parseLibertyFile and readLibertyFile#375hongted wants to merge 2 commits into
hongted wants to merge 2 commits into
Conversation
Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to parse and read Liberty files directly from an input stream (std::istream) across the Sta, LibertyParser, and LibertyReader classes, supported by a new unit test for in-memory parsing. It also applies widespread formatting updates. The review feedback points out a few minor issues to address: a misleading parameter name filename for a stream reference in LibertyReaderPvt.hh, a redundant semicolon in LibertyReader.cc, and grammatical typos in the comments of Sta.hh and LibertyParser.hh.
Contributor
|
The PR includes a lot of white space changes due to clang format. You might want to try to break those changes up from the is PR. |
Signed-off-by: Ted Hong <tedhong@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #350