Skip to content

DATA: WorkloadUpdateTask #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mabroukmahdhi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DATA: WorkloadUpdateTask #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ff2c08
DATA: InstallPlaywrightTask
mabroukmahdhi Jan 24, 2025
f7a12d1
DATA: WorkloadUpdateTask
mabroukmahdhi Jan 24, 2025
b248ad0
CODE RUB: Add Summary
mabroukmahdhi Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ADotNet/Models/Pipelines/GithubPipelines/DotNets/Tasks/InstallPlaywrightTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// ---------------------------------------------------------------------------
// Copyright (c) Hassan Habib & Shri Humrudha Jagathisun All rights reserved.
// Licensed under the MIT License.
// See License.txt in the project root for license information.
// ---------------------------------------------------------------------------

namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets.Tasks
{
public class InstallPlaywrightTask : GithubTask

@cjdutoit cjdutoit Jan 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not expecting this file. There is another open PR for this component. Can we remove this file from the PR so components can be reviewed individually

@mabroukmahdhi mabroukmahdhi Jan 27, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, That's because this PR's branche is based on the other one @cjdutoit

{
public override string Run { get; set; } = "dotnet tool install --global Microsoft.Playwright.CLI";
}
}
27 changes: 27 additions & 0 deletions ADotNet/Models/Pipelines/GithubPipelines/DotNets/Tasks/WorkloadUpdateTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// ---------------------------------------------------------------------------
// Copyright (c) Hassan Habib & Shri Humrudha Jagathisun All rights reserved.
// Licensed under the MIT License.
// See License.txt in the project root for license information.
// ---------------------------------------------------------------------------

namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets.Tasks
{
/// <summary>
/// Represents a task that updates the installed workloads in the .NET SDK.
/// </summary>
public class WorkloadUpdateTask : GithubTask
{
/// <summary>
/// Gets or sets the name of the task.
/// The default value is: "Update installed workloads in the .NET SDK".
/// </summary>
public override string Name { get; set; } = "Update installed workloads in the .NET SDK";

/// <summary>
/// Gets or sets the command to execute for the task.
/// The command updates all installed workloads in the .NET SDK to their latest versions.
/// The default value is: "dotnet workload update".
/// </summary>
public override string Run { get; set; } = "dotnet workload update";

@cjdutoit cjdutoit Jan 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add descriptive documentation.

@cjdutoit cjdutoit Jan 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hassanhabib don't have an issue with this task itself, but but do we have some criteria on when to allow new tasks VS just using the generic task command in the job like below?

                    new GithubTask()
                    {
                        Name = "Update installed workloads",
                        Run = "dotnet workload update"
                    },

}
}