Skip to content

MINOR FIX: Quotes / Backticks In The Body Break Shell Command#156

Merged
cjdutoit merged 4 commits into
mainfrom
users/cjdutoit/minorfix-linter-requireissueortaskjob
May 8, 2026
Merged

MINOR FIX: Quotes / Backticks In The Body Break Shell Command#156
cjdutoit merged 4 commits into
mainfrom
users/cjdutoit/minorfix-linter-requireissueortaskjob

Conversation

@cjdutoit

@cjdutoit cjdutoit commented May 8, 2026

Copy link
Copy Markdown
Collaborator

closes #155

Summary

This the issue where PR body content broke the Check For Associated Issues Or Tasks step.

The below sample text would break the step because of quotes, backticks, bullets etc

Bug Fixes

  • GetDictionaryValues(object) — fixed crash on empty List<string> via Aggregate
  • UpsertDataList(string, string) — fixed silent data loss when key holds a non-List<string> value
  • AddData(IDictionary) — normalizes string[] values to List<string> to match the library's internal storage contract
  • Don't break on apostrophes: it's, won't, can't, you're, they've, we'd, I'm
  • Mixed quotes: "double", 'single', backtick, ‘smart-left’, ’smart-right’, “smart-double-left”, ”smart-double-right”
  • Unmatched quote on purpose: here's a lone ' and a lone " and a lone ` to torture xargs
  • Triple backticks inline: ``` and ```` and even `````
  • Dollar signs and command-substitution bait: $PATH, ${HOME}, $(rm -rf /), whoami, $(id)
  • Backslashes and escapes: \n \t \r \ " ' `
  • Pipes, redirects, semicolons: a | b ; c && d || e > f < g
  • Heredoc bait: <<EOF ... EOF and <<'EOF' ... EOF
  • Null-ish and control-ish text: \0, \x00, ^M, ^@
  • Unicode bullets and dashes: • – — … « » ‹ › „ ‟
  • Emoji: 🚀 ✅ ❌ 🐛 💥 🔥
  • HTML-ish: <script>alert('xss')</script> & & ' "
  • YAML-ish: key: value, - item, ? mapping, & anchor, * alias, ! tag, | block, > folded

@github-actions github-actions Bot added the MINOR FIX A minor bug fix / change that do not significantly alter the overall functionality of the program label May 8, 2026
@cjdutoit cjdutoit merged commit 8ca4a1e into main May 8, 2026
5 checks passed
@cjdutoit cjdutoit deleted the users/cjdutoit/minorfix-linter-requireissueortaskjob branch May 8, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MINOR FIX A minor bug fix / change that do not significantly alter the overall functionality of the program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MINOR FIX: Quotes / Backticks In The Body Break Shell Command

2 participants