Skip to content

CODE RUB: ContributionType Delete Tests#305

Merged
glhays merged 25 commits into
The-Standard-Organization:mainfrom
SlimAhmad:users/slimahmad/controllers/contribtionType-Delete
Jun 7, 2025
Merged

CODE RUB: ContributionType Delete Tests#305
glhays merged 25 commits into
The-Standard-Organization:mainfrom
SlimAhmad:users/slimahmad/controllers/contribtionType-Delete

Conversation

@SlimAhmad

@SlimAhmad SlimAhmad commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

Closes #242

@SlimAhmad

SlimAhmad commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator Author

image

@SlimAhmad

SlimAhmad commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator Author

@glhays @cjdutoit please can we have these reviewed and merged, in order for me to do for contributions

@SlimAhmad SlimAhmad requested review from cjdutoit and glhays March 25, 2025 14:15
@SlimAhmad SlimAhmad added the CONTROLLERS When creating an exposer like a REST API label Mar 25, 2025
@glhays glhays changed the title CONTROLLERS: ContributionType Controller - Delete MEDIUM CONTROLLERS: ContributionType Delete Tests Mar 27, 2025
@glhays glhays added MEDIUM CONTROLLERS and removed CONTROLLERS When creating an exposer like a REST API labels Mar 27, 2025
@cjdutoit cjdutoit marked this pull request as draft March 28, 2025 15:34
@SlimAhmad SlimAhmad marked this pull request as ready for review April 4, 2025 19:18
@cjdutoit cjdutoit marked this pull request as draft April 9, 2025 11:42
@SlimAhmad SlimAhmad marked this pull request as ready for review April 15, 2025 10:19
@glhays glhays changed the title MEDIUM CONTROLLERS: ContributionType Delete Tests CODERUB: ContributionType Delete Tests Apr 26, 2025
@glhays glhays added the CODE RUB Small change to fix things styling, code formatting, spelling (Not for bug fixes)fixes) label Apr 26, 2025
@glhays glhays changed the title CODERUB: ContributionType Delete Tests CODE RUB: ContributionType Delete Tests Apr 26, 2025
@glhays glhays removed their request for review April 26, 2025 19:37
@SlimAhmad SlimAhmad requested a review from aosunlana April 26, 2025 19:44
glhays
glhays reviewed May 23, 2025
View reviewed changes
Comment thread ...sts.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Outdated
Comment thread ...sts.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Outdated
Comment thread ...sts.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Outdated
Comment thread ...sts.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Outdated
Comment thread ...sts.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Outdated
Comment thread ...sts.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Outdated
Comment thread ...sts.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Outdated
Comment thread ...sts.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Outdated
@glhays

glhays commented May 28, 2025

Copy link
Copy Markdown
Collaborator

@SlimAhmad need to resolve the conflicts

@SlimAhmad

SlimAhmad commented May 29, 2025

Copy link
Copy Markdown
Collaborator Author

@glhays done

@SlimAhmad SlimAhmad self-assigned this May 30, 2025
@glhays glhays merged commit 6867b87 into The-Standard-Organization:main Jun 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aosunlana aosunlana aosunlana left review comments

@glhays glhays glhays approved these changes

@cjdutoit cjdutoit Awaiting requested review from cjdutoit

Assignees

@SlimAhmad SlimAhmad

Labels

CODE RUB Small change to fix things styling, code formatting, spelling (Not for bug fixes)fixes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MEDIUM CONTROLLERS: ContributionType Delete Tests

3 participants

@SlimAhmad @glhays @aosunlana