Skip to content

MINOR FOUNDATIONS: Modify Contributor => Source FK Test #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glhays merged 5 commits into from
May 29, 2025
Merged

MINOR FOUNDATIONS: Modify Contributor => Source FK Test #326

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d1c137
ShouldThrowValidationExceptionOnModifyIfReferenceErrorOccursAndLogItA…
SlimAhmad May 1, 2025
2d40125
CODE RUB: Removed extra namspaces
SlimAhmad May 1, 2025
d2b517e
Merge branch 'main' into users/slimahmad/minor-foundations/contributo…
glhays May 28, 2025
7b29a10
Merge branch 'main' into users/slimahmad/minor-foundations/contributo…
SlimAhmad May 29, 2025
9756175
Merge branch 'users/slimahmad/minor-foundations/contributor-fk-test-m…
SlimAhmad May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions ...Tests.Unit/Services/Foundations/Contributors/ContributorServiceTests.Exceptions.Modify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Threading.Tasks;
using EFxceptions.Models.Exceptions;
using FluentAssertions;
using GitFyle.Core.Api.Models.Foundations.Contributors;
using GitFyle.Core.Api.Models.Foundations.Contributors.Exceptions;
Expand Down Expand Up @@ -70,6 +71,67 @@ await Assert.ThrowsAsync<ContributorDependencyException>(
this.loggingBrokerMock.VerifyNoOtherCalls();
}

[Fact]
public async Task ShouldThrowValidationExceptionOnModifyIfReferenceErrorOccursAndLogItAsync()
{
// given
Contributor foreignKeyConflictedContributor = CreateRandomContributor();
string randomMessage = GetRandomString();
string exceptionMessage = randomMessage;

var foreignKeyConstraintConflictException =
new ForeignKeyConstraintConflictException(message: exceptionMessage);

var invalidContributorReferenceException =
new InvalidReferenceContributorException(
message: "Invalid contributor reference error occurred.",
innerException: foreignKeyConstraintConflictException,
data: foreignKeyConstraintConflictException.Data);

var expectedContributorDependencyValidationException =
new ContributorDependencyValidationException(
message: "Contributor dependency validation error occurred, fix errors and try again.",
innerException: invalidContributorReferenceException,
data: invalidContributorReferenceException.Data);

this.dateTimeBrokerMock.Setup(broker =>
broker.GetCurrentDateTimeOffsetAsync())
.Throws(foreignKeyConstraintConflictException);

// when
ValueTask<Contributor> modifyContributorTask =
this.contributorService.ModifyContributorAsync(foreignKeyConflictedContributor);

ContributorDependencyValidationException actualContributorDependencyValidationException =
await Assert.ThrowsAsync<ContributorDependencyValidationException>(
modifyContributorTask.AsTask);

// then
actualContributorDependencyValidationException.Should().BeEquivalentTo(
expectedContributorDependencyValidationException);

this.dateTimeBrokerMock.Verify(broker =>
broker.GetCurrentDateTimeOffsetAsync(),
Times.Once);

this.storageBrokerMock.Verify(broker =>
broker.SelectContributorByIdAsync(foreignKeyConflictedContributor.Id),
Times.Never);

this.loggingBrokerMock.Verify(broker =>
broker.LogErrorAsync(It.Is(SameExceptionAs(
expectedContributorDependencyValidationException))),
Times.Once);

this.storageBrokerMock.Verify(broker =>
broker.UpdateContributorAsync(foreignKeyConflictedContributor),
Times.Never);

this.dateTimeBrokerMock.VerifyNoOtherCalls();
this.storageBrokerMock.VerifyNoOtherCalls();
this.loggingBrokerMock.VerifyNoOtherCalls();
}

[Fact]
public async Task ShouldThrowDependencyExceptionOnModifyIfDatabaseUpdateExceptionOccursAndLogItAsync()
{
Expand Down