Skip to content

MINOR CODE RUB: Code Cleanup#330

Merged
glhays merged 5 commits into
mainfrom
users/glhays/coderub-general-codecleanup
May 28, 2025
Merged

MINOR CODE RUB: Code Cleanup#330
glhays merged 5 commits into
mainfrom
users/glhays/coderub-general-codecleanup

Conversation

@glhays

@glhays glhays commented May 27, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@glhays glhays changed the title CODE RUB: Code Cleanup MINOR CODE RUB: Code Cleanup May 27, 2025
@glhays glhays requested a review from Copilot May 27, 2025 22:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A minor code cleanup reducing unused references and correcting naming inconsistencies.

  • Changed the exception parameter type in FailedOperationContributionException from DbUpdateException to Exception.
  • Renamed the misnamed variable in SourcesController from "sourcees" to "sources".
  • Removed unused using statements and temporary file references in project and test files.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
GitFyle.Core.Api/Models/Foundations/Contributions/Exceptions/FailedOperationContributionException.cs Changed exception parameter type and removed unused members to simplify the exception.
GitFyle.Core.Api/GitFyle.Core.Api.csproj Removed a temporary file reference from the project file.
GitFyle.Core.Api/Controllers/SourcesController.cs Renamed misnamed variable from "sourcees" to "sources" for clarity.
GitFyle.Core.Api.Tests.Unit/Controllers/Contributions/ContributionsControllerTests.Exceptions.Put.cs Removed unused using statements for cleanup.
GitFyle.Core.Api.Tests.Unit/Controllers/ContributionTypes/ContributionTypesControllerTests.Exceptions.Delete.cs Removed an unneeded using statement.
GitFyle.Core.Api.Tests.Acceptance/Apis/Repositories/RepositoriesApiTests.cs Removed unused using statement from acceptance tests.

@glhays glhays requested a review from cjdutoit May 27, 2025 22:55
Comment thread GitFyle.Core.Api/Controllers/ContributionsController.cs Outdated
Comment thread GitFyle.Core.Api/Controllers/ContributionsController.cs Outdated
Comment thread GitFyle.Core.Api/Controllers/ContributionsController.cs Outdated
Comment thread GitFyle.Core.Api/Controllers/ContributionsController.cs
Comment thread GitFyle.Core.Api/GitFyle.Core.Api.csproj Outdated
Comment thread GitFyle.Core.Api/Controllers/ContributionTypesController.cs Outdated
@glhays glhays merged commit 177c8d4 into main May 28, 2025
2 checks passed
@glhays glhays deleted the users/glhays/coderub-general-codecleanup branch May 28, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants