Skip to content

MINOR CONTROLLERS: Repository InvalidReference Post-Put #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glhays wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MINOR CONTROLLERS: Repository InvalidReference Post-Put #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6931281
Controllers -> InvalidReference Post-Put
glhays Jun 14, 2025
058c6a1
Controllers Post-Put Tests
glhays Jun 14, 2025
3a3da8e
CODE RUB: Formatting Comment Resolution
glhays Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion ...re.Api.Tests.Unit/Controllers/Repositories/RepositoriesControllerTests.Exceptions.Post.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,5 +123,49 @@ public async Task ShouldReturnConflictOnPostIfAlreadyExistsRepositoryErrorOccurr

this.repositoryServiceMock.VerifyNoOtherCalls();
}

[Fact]
public async Task ShouldReturnFailedDependencyOnPostIfRepositoryReferenceIsInvalidAsync()
{
// given
Repository someRepository = CreateRandomRepository();
var someInnerException = new Exception();
string someMessage = GetRandomString();

var invalidReferenceRepositoryException =
new InvalidRepositoryReferenceException(
message: someMessage,
innerException: someInnerException,
data: someInnerException.Data);

var repositoryDependencyValidationException =
new RepositoryDependencyValidationException(
message: someMessage,
innerException: invalidReferenceRepositoryException,
data: invalidReferenceRepositoryException.Data);

FailedDependencyObjectResult expectedFailedDependencyObjectResult =
FailedDependency(invalidReferenceRepositoryException);

var expectedActionResult =
new ActionResult<Repository>(expectedFailedDependencyObjectResult);

this.repositoryServiceMock.Setup(service =>
service.AddRepositoryAsync(It.IsAny<Repository>()))
.ThrowsAsync(repositoryDependencyValidationException);

// when
ActionResult<Repository> actualActionResult =
await this.repositoriesController.PostRepositoryAsync(someRepository);

// then
actualActionResult.ShouldBeEquivalentTo(expectedActionResult);

this.repositoryServiceMock.Verify(service =>
service.AddRepositoryAsync(It.IsAny<Repository>()),
Times.Once);

this.repositoryServiceMock.VerifyNoOtherCalls();
}
}
}
}
46 changes: 45 additions & 1 deletion ...ore.Api.Tests.Unit/Controllers/Repositories/RepositoriesControllerTests.Exceptions.Put.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,5 +163,49 @@ public async Task ShouldReturnConflictOnPutIfAlreadyExistsRepositoryErrorOccursA

this.repositoryServiceMock.VerifyNoOtherCalls();
}

[Fact]
public async Task ShouldReturnFailedDependencyOnPutIfRepositoryReferenceIsInvalidAsync()
{
Comment thread
glhays marked this conversation as resolved.
// given
Repository someRepository = CreateRandomRepository();
var someInnerException = new Exception();
string someMessage = GetRandomString();

var invalidReferenceRepositoryException =
new InvalidRepositoryReferenceException(
message: someMessage,
innerException: someInnerException,
data: someInnerException.Data);

var repositoryDependencyValidationException =
new RepositoryDependencyValidationException(
message: someMessage,
innerException: invalidReferenceRepositoryException,
data: invalidReferenceRepositoryException.Data);

FailedDependencyObjectResult expectedFailedDependencyObjectResult =
FailedDependency(invalidReferenceRepositoryException);

var expectedActionResult =
new ActionResult<Repository>(expectedFailedDependencyObjectResult);

this.repositoryServiceMock.Setup(service =>
service.AddRepositoryAsync(It.IsAny<Repository>()))
.ThrowsAsync(repositoryDependencyValidationException);

// when
ActionResult<Repository> actualActionResult =
await this.repositoriesController.PostRepositoryAsync(someRepository);

// then
actualActionResult.ShouldBeEquivalentTo(expectedActionResult);

this.repositoryServiceMock.Verify(service =>
service.AddRepositoryAsync(It.IsAny<Repository>()),
Times.Once);

this.repositoryServiceMock.VerifyNoOtherCalls();
}
}
}
}
10 changes: 10 additions & 0 deletions GitFyle.Core.Api/Controllers/RepositoriesController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ public async ValueTask<ActionResult<Repository>> PostRepositoryAsync(Repository
{
return BadRequest(repositoryValidationException.InnerException);
}
catch (RepositoryDependencyValidationException repositoryDependencyValidationException)
when (repositoryDependencyValidationException.InnerException is InvalidRepositoryReferenceException)
{
return FailedDependency(repositoryDependencyValidationException.InnerException);
}
catch (RepositoryDependencyValidationException repositoryDependencyValidationException)
when (repositoryDependencyValidationException.InnerException is AlreadyExistsRepositoryException)
{
Expand Down Expand Up @@ -127,6 +132,11 @@ public async ValueTask<ActionResult<Repository>> PutRepositoryAsync(Repository r
{
return BadRequest(repositoryValidationException.InnerException);
}
catch (RepositoryDependencyValidationException repositoryDependencyValidationException)
when (repositoryDependencyValidationException.InnerException is InvalidRepositoryReferenceException)
{
return FailedDependency(repositoryDependencyValidationException.InnerException);
}
catch (RepositoryDependencyValidationException repositoryDependencyValidationException)
when (repositoryDependencyValidationException.InnerException is AlreadyExistsRepositoryException)
{
Expand Down