improves the logic for getting the status of completed model runs#23
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 314 327 +13
Branches 29 33 +4
=========================================
+ Hits 314 327 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts how model-run status is derived so that completed runs can be reported from Azure Table Storage without requiring an Azure Container Instance (ACI) lookup (which may no longer exist for completed/cleaned-up runs).
Changes:
- Extend ATS progress retrieval to handle missing
progressand to mark completed runs asstatus="complete". - Short-circuit
get_model_run_statusto return ATS-derived progress whencontainer_group_nameis missing (avoids ACI calls). - Add unit tests covering completed ATS entries without
container_group_name, and ensuring no ACI call is made in that case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/unit/nhp/aci/status/test_status_model_run_status.py |
Adds tests for completed ATS status without container group name and ensures ACI isn’t queried when absent. |
src/nhp/aci/status/model_run_status.py |
Updates ATS progress parsing and adds early-return behavior when container_group_name is missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
fixed |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
c068371 to
a5fba3c
Compare
No description provided.