Skip to content

improves the logic for getting the status of completed model runs#23

Merged
tomjemmett merged 4 commits into
mainfrom
improve_status_logic
May 15, 2026
Merged

improves the logic for getting the status of completed model runs#23
tomjemmett merged 4 commits into
mainfrom
improve_status_logic

Conversation

@tomjemmett

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 13, 2026 14:13
@tomjemmett tomjemmett requested a review from a team as a code owner May 13, 2026 14:13
@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7fdea1d) to head (a5fba3c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          314       327   +13     
  Branches        29        33    +4     
=========================================
+ Hits           314       327   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how model-run status is derived so that completed runs can be reported from Azure Table Storage without requiring an Azure Container Instance (ACI) lookup (which may no longer exist for completed/cleaned-up runs).

Changes:

  • Extend ATS progress retrieval to handle missing progress and to mark completed runs as status="complete".
  • Short-circuit get_model_run_status to return ATS-derived progress when container_group_name is missing (avoids ACI calls).
  • Add unit tests covering completed ATS entries without container_group_name, and ensuring no ACI call is made in that case.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/unit/nhp/aci/status/test_status_model_run_status.py Adds tests for completed ATS status without container group name and ensures ACI isn’t queried when absent.
src/nhp/aci/status/model_run_status.py Updates ATS progress parsing and adds early-return behavior when container_group_name is missing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/nhp/aci/status/model_run_status.py Outdated
Comment thread src/nhp/aci/status/model_run_status.py
@tomjemmett

tomjemmett commented May 15, 2026

Copy link
Copy Markdown
Member Author

fixing tests now. tests aren't failing, but not hitting the new branches in _status_single_model_run

fixed

@tomjemmett tomjemmett force-pushed the improve_status_logic branch from c068371 to a5fba3c Compare May 15, 2026 08:33
@tomjemmett tomjemmett merged commit fa4a841 into main May 15, 2026
6 checks passed
@tomjemmett tomjemmett deleted the improve_status_logic branch May 15, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants