fix issue with uploading params to queue#24
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 314 314
Branches 29 29
=========================================
Hits 314 314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug where upload_params_to_blob used metadata["id"] to name the blob; it now uses metadata["container_group_name"], matching what callers actually provide. Tests are updated accordingly.
Changes:
- Use
container_group_nameinstead ofidfor the blob filename inupload_params_to_blob. - Update related unit tests to pass
container_group_namein metadata.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/nhp/aci/run_model/storage.py | Switches blob filename key from id to container_group_name. |
| tests/unit/nhp/aci/run_model/test_run_model_storage.py | Updates test metadata to use the new key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
was using the old "id" value, now should be "container_group_name"
tomjemmett
force-pushed
the
fix_queue_filename
branch
from
b0035ea to
8365163
Compare
yiwen-h
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was using the old "id" value, now should be "container_group_name"