Skip to content

fix _run in main to use model_run_id not deprecated id#28

Merged
yiwen-h merged 2 commits into
mainfrom
bugfix-v5
May 19, 2026
Merged

fix _run in main to use model_run_id not deprecated id#28
yiwen-h merged 2 commits into
mainfrom
bugfix-v5

Conversation

@yiwen-h
Copy link
Copy Markdown
Member

@yiwen-h yiwen-h commented May 19, 2026

No description provided.

@yiwen-h yiwen-h requested review from a team and tomjemmett as code owners May 19, 2026 10:00
Copy link
Copy Markdown
Member

@tomjemmett tomjemmett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing:

you should be able to fix by replacing m_create with


        m_create = mocker.patch(
            "nhp.aci.__main__.create_model_run", return_value={"model_run_id": "id"}
        )

in TestRun

  • test_just_params_file_with_app_version_in_params
  • test_just_params_file_without_app_version_in_params
  • test_setting_app_version
  • test_setting_dataset

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d545bba) to head (367d67f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          325       325           
  Branches        33        33           
=========================================
  Hits           325       325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomjemmett tomjemmett self-requested a review May 19, 2026 10:09
@yiwen-h yiwen-h merged commit 9a5c3c4 into main May 19, 2026
6 checks passed
@yiwen-h yiwen-h deleted the bugfix-v5 branch May 19, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants