Skip to content

add functionality to delete record from ats when cleaning runs#32

Merged
yiwen-h merged 2 commits into
mainfrom
31_clean-ats-when-deleting-container
Jun 1, 2026
Merged

add functionality to delete record from ats when cleaning runs#32
yiwen-h merged 2 commits into
mainfrom
31_clean-ats-when-deleting-container

Conversation

@yiwen-h

@yiwen-h yiwen-h commented Jun 1, 2026

Copy link
Copy Markdown
Member

Closes #31

Previously when cancelling runs with nhp_aci clean command, the container and the params file would be deleted but the record would remain on ATS, forever showing status: running

This PR deletes the ATS record when a model run is cleaned.

Alternative would be to mark the ATS record status as Cancelled - would this be preferred?

@yiwen-h yiwen-h requested review from a team and tomjemmett as code owners June 1, 2026 11:56
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c91b228) to head (f5dfedb).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          352       361    +9     
  Branches        37        37           
=========================================
+ Hits           352       361    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yiwen-h yiwen-h merged commit 31333a6 into main Jun 1, 2026
6 checks passed
@yiwen-h yiwen-h deleted the 31_clean-ats-when-deleting-container branch June 1, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete model runs from ATS when cancelled with CLEAN command

2 participants