Remove time-profiles modules and references in other modules#655
Merged
Conversation
matt-dray
added
should
matt-dray
force-pushed
the
650-rm-time-profile-mod
branch
from
June 8, 2026 16:47
29cf48c to
d1a00c0
Compare
matt-dray
changed the title
matt-dray
marked this pull request as ready for review
June 8, 2026 17:41
StatsRhian
approved these changes
Jun 10, 2026
StatsRhian
left a comment
StatsRhian
left a comment
Member
There was a problem hiding this comment.
Nice! Glad to see 🔥 lines deleted!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #650.
I've tested this locally in conjunction with #688. Newly-generated params do not contain time-profile mappings and upgraded params have them removed, as expected. The params passes dev schema, which has been updated to remove the time-profile requirement (The-Strategy-Unit/nhp_model#624). The box for time-profile selection is removed from the modules where it used to appear, as expected.