use oidc with sync action#686
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the sync-data GitHub Actions workflow to authenticate to Azure Blob Storage using OIDC + a managed identity instead of SAS tokens, reducing long-lived credentials and enabling scoped access via Azure RBAC.
Changes:
- Adds
azure/login@v3and enables OIDC (permissions: id-token: write) for Azure authentication. - Removes SAS-token based azcopy URLs and switches azcopy to use Azure CLI auth (
AZCOPY_AUTO_LOGIN_TYPE=AZCLI). - Pins the job to the
productionGitHub environment to match the federated credential configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matt-dray
approved these changes
Jun 11, 2026
matt-dray
left a comment
Contributor
There was a problem hiding this comment.
Cheers, you demoed this for @StatsRhian and me yesterday along with #624. You and I also walked through it last week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switches from using sas tokens to OIDC.
this has the benefit that we use a managed identity in azure with specifically scoped access to the data, and through OIDC we get a fresh token as needed.
there were some aditional setup steps, detailed below:
We have manaually tested that his action works using the workflow dispatch.