switch to watcher package#693
Merged
Merged
Conversation
uses shiny 1.14 and the watcher package, using shiny::devmode in the dev/watch.R script. devmode turns on some extra checks, which throws warnings due to gt creating and input and output with the same id for every table. switching from gt_output to htmlOutput resolves this (though, it will break interactive gt tables)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Shiny dev workflow and gt table outputs to work with shiny::devmode() checks by replacing gt::gt_output() UI bindings with shiny::htmlOutput(), and adjusts package dependencies accordingly.
Changes:
- Replace multiple
gt::gt_output()UI elements withshiny::htmlOutput()to avoiddevmode()warnings (at the cost of breaking interactive gt features). - Update
dev/watch.Rto enableshiny::devmode()and simplify app launching. - Update dependency metadata (
shinyminimum version; swapwatchr→watcher) and removegolem.app.prodoption fromapp.R.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| R/mod_waiting_list_imbalances_ui.R | Switch gt table UI from gt_output() to htmlOutput(). |
| R/mod_run_model_ui.R | Switch validation errors UI from gt_output() to htmlOutput(). |
| R/mod_non_demographic_adjustment_ui.R | Switch adjustment table UI from gt_output() to htmlOutput(). |
| R/mod_mitigators_ui.R | Switch diagnoses/procedures gt table UIs from gt_output() to htmlOutput(). |
| R/mod_mitigators_summary_ui.R | Switch summary gt table UI from gt_output() to htmlOutput(). |
| R/mod_home_ui.R | Switch model options gt table UI from gt_output() to htmlOutput(). |
| dev/watch.R | Enable shiny::devmode() and change dev launcher behavior. |
| DESCRIPTION | Bump Shiny minimum version and replace watchr with watcher in Suggests. |
| app.R | Remove explicit golem.app.prod option setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matt-dray
approved these changes
Jul 2, 2026
matt-dray
left a comment
matt-dray
left a comment
Contributor
There was a problem hiding this comment.
Thank you, tested locally and it works as I would expect. Pairs with The-Strategy-Unit/nhp_outputs#452.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses shiny 1.14 and the watcher package, using shiny::devmode in the dev/watch.R script.
devmode turns on some extra checks, which throws warnings due to gt creating and input and output with the same id for every table. switching from gt_output to htmlOutput resolves this (though, it will break interactive gt tables)