Skip to content

update actions to generate manifest.json#694

Draft
tomjemmett wants to merge 6 commits into
mainfrom
update_actions
Draft

update actions to generate manifest.json#694
tomjemmett wants to merge 6 commits into
mainfrom
update_actions

Conversation

@tomjemmett

Copy link
Copy Markdown
Member

Generate the manifest.json file in actions. cleans up the example Renviron which has some unused values in, and renames the environment used in the sync data step.

Copilot AI review requested due to automatic review settings July 2, 2026 11:33
@tomjemmett
tomjemmett requested a review from a team as a code owner July 2, 2026 11:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves manifest.json generation into GitHub Actions (via an R script) instead of maintaining it with Node scripts, and updates deployment/sync workflows and example environment configuration accordingly.

Changes:

  • Remove the Node-based manifest update scripts and rely on rsconnect::writeManifest() for manifest generation.
  • Update the reusable Connect publish workflow to generate/upload manifest.json and adjust environment/variable usage.
  • Rename the GitHub Actions environment used by the sync-data job and tidy .Renviron.example.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
update_manifest.js Deleted Node script previously used to update manifest.json.
remove_files_from_manifest.js Deleted Node script that blanked manifest.json file entries.
dev/generate_manifest.R Stops post-processing manifest; relies on rsconnect::writeManifest().
.Renviron.example Removes unused example entries and reorders CACHE_VERSION.
.github/workflows/sync-data.yaml Changes job environment from production to sync-data.
.github/workflows/connect-publish-prod.yaml Adjusts environment naming passed to the reusable publish workflow.
.github/workflows/connect-publish-manual.yaml Generates/uploads manifest in CI; broadens environment input handling; switches some values from secrets to vars.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/sync-data.yaml
Comment thread .github/workflows/connect-publish-manual.yaml
@tomjemmett
tomjemmett marked this pull request as draft July 2, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants