Skip to content

use the inputs selection app package#701

Open
tomjemmett wants to merge 3 commits into
mainfrom
use_inputs_selection_app_pkg
Open

use the inputs selection app package#701
tomjemmett wants to merge 3 commits into
mainfrom
use_inputs_selection_app_pkg

Conversation

@tomjemmett

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 14, 2026 21:12
@tomjemmett
tomjemmett requested a review from a team as a code owner July 14, 2026 21:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the development watcher script to launch the inputs selection app via its dedicated R package, and wires up the dependency so it can be installed from GitHub as part of dev dependencies.

Changes:

  • Switch dev/watch.R from shiny::runApp("inputs_selection_app", ...) to nhp.inputs.selection.app::run_app(...).
  • Add nhp.inputs.selection.app to Suggests and specify its GitHub remote in DESCRIPTION.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
dev/watch.R Uses the selection app’s package entrypoint (run_app) instead of running a local app directory.
DESCRIPTION Adds the selection app package to Suggests and points Remotes to its GitHub repository for installation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DESCRIPTION Outdated
@matt-dray matt-dray added enhancement New feature or request must MoSCoW priority labels Jul 15, 2026
@matt-dray matt-dray added this to the v5.2.1 milestone Jul 15, 2026

@matt-dray matt-dray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb, this is a much neater solution and works as expected. Thank you for implementing this.

We can hold this back until there's a true launch with a minor release, or we can go ahead this sprint and release as v5.2.1. Preference?

Related: we can delete the orphan inputs_selection_app branch at that point as well, given the history is now in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request must MoSCoW priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants