use the inputs selection app package#701
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the development watcher script to launch the inputs selection app via its dedicated R package, and wires up the dependency so it can be installed from GitHub as part of dev dependencies.
Changes:
- Switch
dev/watch.Rfromshiny::runApp("inputs_selection_app", ...)tonhp.inputs.selection.app::run_app(...). - Add
nhp.inputs.selection.apptoSuggestsand specify its GitHub remote inDESCRIPTION.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dev/watch.R | Uses the selection app’s package entrypoint (run_app) instead of running a local app directory. |
| DESCRIPTION | Adds the selection app package to Suggests and points Remotes to its GitHub repository for installation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matt-dray
left a comment
There was a problem hiding this comment.
Superb, this is a much neater solution and works as expected. Thank you for implementing this.
We can hold this back until there's a true launch with a minor release, or we can go ahead this sprint and release as v5.2.1. Preference?
Related: we can delete the orphan inputs_selection_app branch at that point as well, given the history is now in the repo.
No description provided.