updates test snapshots#634
Merged
Merged
Conversation
following changes to synthetic data
✅ A new build is available.You can use the following to use pull the image into your local environment: docker pull ghcr.io/the-strategy-unit/nhp_model:pr-634 |
Member
Author
|
this should go in before #633 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1131 1131
Branches 58 58
=========================================
Hits 1131 1131 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates stored integration and E2E regression-test snapshots to reflect recent changes in the synthetic dataset used by the NHP demand model test runs.
Changes:
- Refresh integration test CSV snapshots for default aggregates and step-count breakdowns across IP/OP/A&E.
- Refresh the E2E “all model runs (default)” snapshot to align with the updated synthetic data outputs.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/nhp/model/test_single_model_run/test_model_step_counts_op_.csv | Updated OP step-count snapshot values produced by the integration run. |
| tests/integration/nhp/model/test_single_model_run/test_model_step_counts_ip_.csv | Updated IP step-count snapshot values (including newly surfaced pods like regular night attenders). |
| tests/integration/nhp/model/test_single_model_run/test_model_step_counts_aae_.csv | Updated A&E step-count snapshot values produced by the integration run. |
| tests/integration/nhp/model/test_single_model_run/test_model_default_results_op_.csv | Updated OP default aggregation snapshot values. |
| tests/integration/nhp/model/test_single_model_run/test_model_default_results_ip_.csv | Updated IP default aggregation snapshot values (including additional pods now present in results). |
| tests/integration/nhp/model/test_single_model_run/test_model_default_results_aae_.csv | Updated A&E default aggregation snapshot values. |
| tests/e2e/test_run_model_snapshot/test_all_model_runs_default_.csv | Updated E2E snapshot for the combined default-run outputs across model types. |
yiwen-h
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following changes to synthetic data