fix: use strict inequality to avoid containerOutOfBounds#2981
Merged
realstealthninja merged 1 commit intoTheAlgorithms:masterfrom Aug 17, 2025
Merged
fix: use strict inequality to avoid containerOutOfBounds#2981realstealthninja merged 1 commit intoTheAlgorithms:masterfrom
containerOutOfBounds#2981realstealthninja merged 1 commit intoTheAlgorithms:masterfrom
Conversation
4d3eaac to
145d28d
Compare
realstealthninja
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Observe that in the old code, because the
<=is used in the loop, there is an index out of bounds error. The main reason for this PR is to fix this problem. The rest is just fix as you go:std::size_tshould be used for indexing standard containers,buildfunction twice in the old code).Checklist
Notes:
Fix one-off error leading to index out of bounds.