fix: add permissions for Approved label CI (#2719)#2989
Closed
kanishka-raisania wants to merge 2 commits intoTheAlgorithms:masterfrom
Closed
fix: add permissions for Approved label CI (#2719)#2989kanishka-raisania wants to merge 2 commits intoTheAlgorithms:masterfrom
kanishka-raisania wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Signed-off-by: Kanishka Raisania <kanishkaraisania@gmail.com>
Collaborator
|
if i recall correctly, This fix was tried in a previous pr and didn't work, I am writing an action to fix this, But im happy to test this for now, If you would like you could also help me replace the current workflow, Apparently the github repository for the workflow also has been deleted. |
realstealthninja
approved these changes
Sep 1, 2025
realstealthninja
requested changes
Sep 1, 2025
Collaborator
realstealthninja
left a comment
There was a problem hiding this comment.
Nope tests not passing.
kay34-lab
approved these changes
Sep 1, 2025
anandfresh
approved these changes
Sep 6, 2025
Collaborator
|
fixed by #3016 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Added
pull-requests: writepermission to theapproved-label.ymlworkflow.This fixes issue #2719 where the Approved Label CI could not add the "approved" label to PRs due to insufficient permissions (403 error).
Checklist
Notes:
This PR fixes #2719 by updating the workflow permissions.