refactor: input size should not be a template argument in postfix_evaluation#2996
Merged
realstealthninja merged 1 commit intoTheAlgorithms:masterfrom Sep 25, 2025
Conversation
vil02
requested review from
Panquesito7 and
realstealthninja
as code owners
anandfresh
approved these changes
Sep 13, 2025
vil02
force-pushed
the
use_vector_as_input_of_postfix_evaluation
branch
from
0c851e0 to
ad60004
Compare
realstealthninja
pushed a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
realstealthninja
added a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
…stfix_evaluation` (TheAlgorithms#2996)" This reverts commit b6d0448.
realstealthninja
added a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
…stfix_evaluation` (TheAlgorithms#2996)" This reverts commit b6d0448.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Since the input size of
postfix_evaluationis a template parameter, this function needs to be compile for every used input size (this increases both the build time and the size of the binary).This PR changes the the type of the input to
std::vectorto avoid such problem.Checklist
Notes:
Use
std::vectoras input type, to avoid increase of build time and binary size.