Fix: use uint64_t for input and counter in countSetBits#3003
Merged
realstealthninja merged 4 commits intoTheAlgorithms:masterfrom Sep 27, 2025
Merged
Fix: use uint64_t for input and counter in countSetBits#3003realstealthninja merged 4 commits intoTheAlgorithms:masterfrom
realstealthninja merged 4 commits intoTheAlgorithms:masterfrom
Conversation
Contributor
Author
|
I am glad you liked it |
Contributor
Author
Hey some of the files contain similar kind of problem should i fix them as well ? |
realstealthninja
added a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
…s#3003) Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
realstealthninja
added a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
…lgorithms#3003)" This reverts commit a2efdcb.
realstealthninja
added a commit
to realstealthninja/C-Plus-Plus
that referenced
this pull request
Oct 1, 2025
…lgorithms#3003)" This reverts commit a2efdcb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Updated the
countSetBitsfunction in bit_manipulation/count_of_set_bits.cpp to improve type safety and correctness:int64_ttouint64_tto ensure only non-negative numbers are allowed.countfrominttouint64_tto match the return type and prevent any theoretical overflow.This ensures the function is consistent, safe, and fully aligned with the intended use of counting set bits in non-negative integers.
Checklist
Notes:
Improves type safety for
countSetBitsfunction without changing its behavior for normal inputs.