fix: correct FCFS template handling and improve self-tests#3193
Open
harshitrajput2802 wants to merge 2 commits into
Open
fix: correct FCFS template handling and improve self-tests#3193harshitrajput2802 wants to merge 2 commits into
harshitrajput2802 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Corrected the FCFS scheduling implementation by fixing a template type mismatch in the reference implementation used for verification. The previous implementation hardcoded the input type to uint32_t, preventing the helper function from correctly supporting arbitrary template parameters.
This update also:
Checklist
Notes: Fixes the FCFS reference implementation to correctly support template parameters and improves randomized self-tests using a modern C++ random number generator.