Enhance IterativeBinarySearch with null safety and improved documentation

Author: Mudita-Singh

src/main/java/com/thealgorithms/searches/BinarySearch.java

@@ -131,43 +131,6 @@ else if (comp < 0) {
             return search(array, key, median + 1, right);
         }
     }
-
-    /**
-     * Iterative implementation of binary search.
-     * This version avoids recursion and uses constant space O(1).
-     *
-     * @param <T> The type of elements in the array (must be Comparable)
-     * @param array The sorted array to search in
-     * @param key The element to search for
-     * @return The index of the key if found, -1 otherwise
-     */
-    public <T extends Comparable<T>> int findIterative(T[] array, T key) {
-
-        // Handle edge cases
-        if (array == null || array.length == 0 || key == null) {
-            return -1;
-        }
-
-        int left = 0;
-        int right = array.length - 1;
-
-        while (left <= right) {
-
-            int median = (left + right) >>> 1;
-
-            int comp = key.compareTo(array[median]);
-
-            if (comp == 0) {
-                return median;
-            } else if (comp < 0) {
-                right = median - 1;
-            } else {
-                left = median + 1;
-            }
-        }
-
-        return -1;
-    }
 }
 
 

src/main/java/com/thealgorithms/searches/IterativeBinarySearch.java

@@ -33,15 +33,22 @@ public final class IterativeBinarySearch implements SearchAlgorithm {
      */
     @Override
     public <T extends Comparable<T>> int find(T[] array, T key) {
-        if (array == null || array.length == 0) {
+
+        // Handle edge cases: null/empty array or null key
+        // Prevents NullPointerException during comparison
+        if (array == null || array.length == 0 || key == null) {
             return -1;
         }
 
         int left = 0;
         int right = array.length - 1;
 
         while (left <= right) {
+
+            // Use unsigned right shift to avoid overflow
+            // Equivalent to (left + right) / 2 but safer for large indices
             int mid = (left + right) >>> 1;
+
             int cmp = key.compareTo(array[mid]);
 
             if (cmp == 0) {
@@ -53,6 +60,7 @@ public <T extends Comparable<T>> int find(T[] array, T key) {
             }
         }
 
+        // Element not found
         return -1;
     }
-}
+}