Fix: handle null key in IterativeBinarySearch#7365
Open
kadambari25 wants to merge 3 commits intoTheAlgorithms:masterfrom
Open
Fix: handle null key in IterativeBinarySearch#7365kadambari25 wants to merge 3 commits intoTheAlgorithms:masterfrom
kadambari25 wants to merge 3 commits intoTheAlgorithms:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7365 +/- ##
=========================================
Coverage 79.46% 79.47%
+ Complexity 7131 7130 -1
=========================================
Files 795 795
Lines 23297 23297
Branches 4587 4587
=========================================
+ Hits 18513 18515 +2
+ Misses 4047 4046 -1
+ Partials 737 736 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Hi, I’ve added a null check for the key parameter to prevent potential NullPointerException. Please let me know if any changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: Handle null key in IterativeBinarySearch
Description
The current implementation of
IterativeBinarySearchhandles null and empty arrays but does not account for a null search key.This can lead to a
NullPointerExceptionwhen calling:Changes Made
keyparameter in thefindmethod:Why this is important
Type of change
Checklist